Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintaining adapter packages? #8

Closed
jankapunkt opened this issue Oct 10, 2021 · 5 comments
Closed

Maintaining adapter packages? #8

jankapunkt opened this issue Oct 10, 2021 · 5 comments
Labels
discussion 🗨️ Discussion about a particular topic. on hold 🛑 We will look into it at a later time

Comments

@jankapunkt
Copy link
Member

Do we want to maintain adapters under this org, too? At least for express I can provide support. One argument for it is, that it will build much more trust and we can ensure this will live on. Argument against is that we have more to maintain overall.

@jankapunkt jankapunkt added the discussion 🗨️ Discussion about a particular topic. label Oct 10, 2021
@jankapunkt
Copy link
Member Author

Another advantage would be to have CI runninng integration tests before publishing releases, e.g. when merging into a release branch

@HappyZombies
Copy link
Member

HappyZombies commented Oct 10, 2021

I think we should, but let's see how this project goes first. If we gain traction and are putting out releases, we can start taking in other adapter packages too under the org.

@jwerre
Copy link
Contributor

jwerre commented Oct 10, 2021

I agree, in fact I've already written an adapter to express which I'd be happy to push.

oauthjs/express-oauth-server#140

@jankapunkt
Copy link
Member Author

@jwerre would you fork it into this org?

@oklas do you want to fork your micron adatapter project into this org, too?

@HappyZombies I think we can add @oklas to the maintainers

@HappyZombies
Copy link
Member

I am ok with the number of maintainers currently, besides like I mentioned we should put a small hold on adding all adapters and what not, we still have administrator stuff to do and whatever else small bug fixes.

I think us three can handle it right now, if it becomes too much we can add more maintainers to handle the adapters and example project(s).

@HappyZombies HappyZombies added the on hold 🛑 We will look into it at a later time label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion 🗨️ Discussion about a particular topic. on hold 🛑 We will look into it at a later time
Projects
None yet
Development

No branches or pull requests

3 participants