Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Roblox Real-Time Chat - Some events may not fire #837

Open
Scriptifer opened this issue Oct 25, 2024 · 1 comment
Open

[BUG] Roblox Real-Time Chat - Some events may not fire #837

Scriptifer opened this issue Oct 25, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Scriptifer
Copy link

Describe the bug
I only have tested the onNewMessage event emitter, so I'm not sure if this is also happening on other event emitters.

In some cases, onNewMessage in Chat won't fire, I have discovered that Roblox is changing the way the real-time chat works in their websockets.

To Reproduce
Steps to reproduce the behavior:

  1. Make a group conversation (this is most likely going to occur in)
  2. Log info on onNewMessage event emitter
  3. Send a message from the other participant in the group conversation.
  4. See console, won't log new message

Expected behavior
onNewMessage to fire when a message is received, including group conversations.

Screenshots
New chat system in websocket when message received:

image

Source code:

image

I recommend ignoring the legacy types, and to change to the new ones, by changing the checks to match the new ones instead of adding || whether if legacy or new.

@Neztore
Copy link
Member

Neztore commented Dec 12, 2024

So is the type now a number instead of a string? Is the other data coming down as expected?
If you understand the intricacies of the behaviour could you open a PR? I'm not too familiar with chats & notifs personally.

@Neztore Neztore added bug Something isn't working help wanted Extra attention is needed labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants