Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing implementation for routine CONVERTER_LOGIC.make #172

Open
miri15 opened this issue Sep 23, 2015 · 7 comments
Open

Missing implementation for routine CONVERTER_LOGIC.make #172

miri15 opened this issue Sep 23, 2015 · 7 comments
Assignees
@miri15
Labels
implementation

Comments

@miri15
Copy link
Collaborator

miri15 commented Sep 23, 2015

No description provided.

@miri15 miri15 self-assigned this Sep 23, 2015
@miri15
Copy link
Collaborator Author

miri15 commented Sep 23, 2015

Solved in rev. 93f4aee

@miri15
Copy link
Collaborator Author

miri15 commented Sep 23, 2015

Correction indentation of poscondition in rev. e0cc59d

@nricci
Copy link
Collaborator

nricci commented Sep 24, 2015

Well done. Although it seems that this constructor gives no extra functionality than what would be achieved by default_create. I'm closing the issue for the time being.

@nricci nricci closed this as completed Sep 24, 2015
@nricci nricci removed the resolved label Sep 24, 2015
@nricci nricci reopened this Sep 24, 2015
@nricci
Copy link
Collaborator

nricci commented Sep 24, 2015

This feature is redundant. Please mark as obsolete, default_create should be called instead.

@miri15
Copy link
Collaborator Author

miri15 commented Sep 24, 2015

Modified in rev a498634

@nricci
Copy link
Collaborator

nricci commented Sep 24, 2015

Well done, thanks!

@nricci nricci closed this as completed Sep 24, 2015
@dromero19
Copy link
Collaborator

Someone has erased the 'obsolete' condition of this constructor. I think that was you @ezedepetris, in this rev. 5bcf4a0. Check it please.

@dromero19 dromero19 reopened this Sep 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miri15 miri15

Labels
implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nricci @dromero19 @miri15