Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is my flow ID? #54

Open
ACharbonneau opened this issue Feb 19, 2021 · 4 comments
Open

What is my flow ID? #54

ACharbonneau opened this issue Feb 19, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ACharbonneau
Copy link
Contributor

in the new docs it says that:

You can specify the following [OPTIONS] with cfde-submit status.

--flow-instance-id=ID is the ID of the particular submission.
--flow-id=ID is the ID of the Flow (NOT a specific submission).

Below is the info I get when I do cfde-submit run:

(cfdesubmit) (base) amandas-mbp-2:cfde-release amanda$ cfde-submit run lincs-metab-4dn/Metabolomics/c2m2/output/
Please enter the CFDE identifier for your Data Coordinating Center: cfde_registry_dcc:metabolomics
Thank you. Would you like to save 'cfde_registry_dcc:metabolomics' for future submissions? y/n: n
Running on service 'staging'
Submit datapackage  using cfde_registry_dcc:metabolomics? (y/N)? > y
DEBUG:cfde_submit.validation:BDBag created at '/Users/amanda/cfde_repos/cfde-release/lincs-metab-4dn/Metabolomics/c2m2/output_0caf7e7d2bbba7ac00d39dcd69e997715f42aea2'
DEBUG:cfde_submit.validation:Archiving BDBag at '/Users/amanda/cfde_repos/cfde-release/lincs-metab-4dn/Metabolomics/c2m2/output_0caf7e7d2bbba7ac00d39dcd69e997715f42aea2' using 'zip'
DEBUG:cfde_submit.validation:BDBag archived to file '/Users/amanda/cfde_repos/cfde-release/lincs-metab-4dn/Metabolomics/c2m2/output_0caf7e7d2bbba7ac00d39dcd69e997715f42aea2.zip'
DEBUG:cfde_submit.validation:Removing old directory '/Users/amanda/cfde_repos/cfde-release/lincs-metab-4dn/Metabolomics/c2m2/output_0caf7e7d2bbba7ac00d39dcd69e997715f42aea2'
DEBUG:cfde_submit.validation:Validating TableSchema in BDBag '/Users/amanda/cfde_repos/cfde-release/lincs-metab-4dn/Metabolomics/c2m2/output_0caf7e7d2bbba7ac00d39dcd69e997715f42aea2.zip'
DEBUG:cfde_submit.validation:Validation successful
DEBUG:cfde_submit.client:Creating input for Flow
DEBUG:cfde_submit.client:Local endpoint: 04b54a52-e93d-11ea-9f05-0aba3c43875b
DEBUG:cfde_submit.client:Using local Globus Connect Personal Endpoint '04b54a52-e93d-11ea-9f05-0aba3c43875b'
Started DERIVA ingest flow
Your dataset has been submitted
You can check the progress with: cfde-submit status

Which things in there are my --flow-instance-id and --flow-id? And if they're not in there, how would I know what they are?

@ACharbonneau ACharbonneau added Testing documentation Improvements or additions to documentation labels Feb 19, 2021
@DavidKelly-Praedictus DavidKelly-Praedictus self-assigned this Feb 19, 2021
@DavidKelly-Praedictus
Copy link
Contributor

DavidKelly-Praedictus commented Feb 19, 2021

There are a few things going on here. First, you shouldn't be seeing those debug messages unless you've manually enabled them. I have a fix for this that I will commit today.

For the second issue, we previously removed the flow id and flow instance id to try to make the output cleaner. But if you're running multiple flows at once, you will need that info. What do you think of the following output instead?

Started DERIVA ingest flow
Your dataset has been submitted
You can check the progress with: cfde-submit status --flow-instance-id ID

@ACharbonneau
Copy link
Contributor Author

That seems more helpful. Is that different from --flow-id? and would I need that?

@ACharbonneau
Copy link
Contributor Author

I'm now told that the tool does not actually support looking at older submission statuses so the docs are wrong and need to be fixed https://github.com/nih-cfde/cfde-submit/blob/main/docs/index.md#status

@NickolausDS
Copy link

Small correction: I believe the docs there should be correct, but the cfde-submit client doesn't do the work of storing multiple submission ids the user can reference at a later time. The cfde-submit client only remembers the last id. It's up to the user to manually track submission UUIDs and supply them with the correct flow-id provided by the cfde-submit status command.

It's my opinion this is confusing and we should scrap this feature in its current form. There are better ways to accomplish this. For example, if a user wanted to know their last five submissions, ideally they would type something like cfde-submit list. The client would spit them all out in order listing the name, date and dcc id for each.

@DavidKelly-Praedictus DavidKelly-Praedictus added enhancement New feature or request and removed documentation Improvements or additions to documentation Testing labels Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants