-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support States within the key parameter #157
Comments
@nvahalik do you mind creating a PR for this issue? |
@marcjulian Sure. I'm working on it now. Looks like this should already work based on how it's configured. It doesn't really make sense, but perhaps the issue here is a build problem and not a code problem? When I use my locally built version of the plugin, using a It reports that I'm unfamiliar enough with how these modules are built to know where to go from here. |
The above was tested w/ Firefox 79 and the project is being used with the |
Ah, OK. I figured out what was going on. PR submitted! #158 |
Note that I was still having problems with using StateToken directly in the |
Currently the
key
option for the importing of the plugin only allows for State Tokens and strings. This causes an error (#123) if you pass in aStateModel
.It should be fairly easy to suppose a
StateModel
object since it has aname
attribute which is the value that needs to be examined rather than thekey
itself.Just check to see if the key is a
StateModel
and if it is, the "real name" iskey.name
rather thankey
.The text was updated successfully, but these errors were encountered: