Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useHostWidth input does not respect value changes from true to false #155

Open
baleeds opened this issue Mar 28, 2024 · 0 comments
Open

Comments

@baleeds
Copy link

baleeds commented Mar 28, 2024

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Currently, the input for useHostWidth on the TippyDirective doesn't apply changes to the input. For instance, if I start with [useHostWidth]="true" and then switch to false, the tippy will continue to use the host's width

Expected behavior

The input for useHostWidth should respect any changes after the directive has been initialized.

Minimal reproduction of the problem with instructions

I have coded up a reproduction in this repository. Instructions are shown when you run the app.
https://github.com/baleeds/helipopper-bug

What is the motivation / use case for changing the behavior?

As far as I can tell, all other inputs respect value changes. Consistency dictates that useHostWidth should do the same. We see the bug in our app when we want to watch a dimension of the parent element as the source for determining whether the tippy should use the host's width.

Environment


Helipopper version: 9.1.0

Angular version: 17.0.9


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@baleeds baleeds changed the title useHostWidth input does not respect value changes after OnInit useHostWidth input does not respect value changes from true to false Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant