Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple variations of contextMenu #103

Open
productivityindustries opened this issue Aug 31, 2022 · 0 comments
Open

multiple variations of contextMenu #103

productivityindustries opened this issue Aug 31, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@productivityindustries
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

If I try to define two different variations of a contextMenu, only the one having name 'contextMenu' will work. The other is ignored.

Expected behavior

Both contextMenus should work.

Minimal reproduction of the problem with instructions

  variations: {
    contextMenu: withContextMenuVariation(popperVariation),
    contextMenuCustom: withContextMenuVariation({...popperVariation, plugins: [myPlugin] }),

What is the motivation / use case for changing the behavior?

In my app I have a page where the content menu should be closed programmatically, through a plugin.
But in the rest of the app, the regular contextMenu variation should be used.

i think it all bolis down to the fact that there can be only one flavor of contextMenu, the one named 'contextMenu': see
https://github.com/ngneat/helipopper/blob/master/projects/ngneat/helipopper/src/lib/tippy.directive.ts#L266

Environment


Angular version: 13


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@NetanelBasal NetanelBasal added enhancement New feature or request good first issue Good for newcomers labels Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants