Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value nginx to ingressClassName for the virtualservers CRD #6893

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hanyouqing
Copy link
Contributor

@hanyouqing hanyouqing commented Dec 3, 2024

Proposed changes

Fix #6891

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@hanyouqing hanyouqing requested a review from a team as a code owner December 3, 2024 08:44
Copy link

github-actions bot commented Dec 3, 2024

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo ☑
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiple NGINX Ingress Controllers doesn't work well
1 participant