Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react-router v4 #35

Open
GiladShoham opened this issue Mar 21, 2017 · 6 comments
Open

Support react-router v4 #35

GiladShoham opened this issue Mar 21, 2017 · 6 comments

Comments

@GiladShoham
Copy link

Hi,
First thanks for this great library!

Is react-metrics supports react-router4?

If no is there any plan/timeline for this?
If yes, is there anything special need to be done?

Thanks!
Gilad

@kylem038
Copy link

We recently took some time to try and implement react-metrics with react-router v4. We did hit an issue where pageviews did not appear to be behaving correctly. Here's a gif of our log. You can see as we route around it seems to cancel the previous pageview session as if it didn't succeed, then starts a new one.

@GazzaHazza
Copy link

Just wondering is there any progress on this at all?

@jamsea
Copy link
Contributor

jamsea commented Feb 8, 2018

@GazzaHazza there are no plans for us to move to react-router 4, so unfortunately we're not working on supporting this in react-metrics. However we're 100% open for a pull request to support this 👍

@potench
Copy link
Contributor

potench commented Feb 8, 2018

Started working on a PR for React 16 in #56, it also contains an upgrade to react-router 3.2. But I haven't tried to upgrade to react-router 4 yet. It might be a good first step to peek at #56 and help get these tests passing. After we land that we can look to upgrade to react-router 4.

@breeny
Copy link

breeny commented Apr 17, 2018

@potench any update on that PR?

@morgs32
Copy link

morgs32 commented Aug 19, 2020

For anyone still having issues with this - we worked to develop a similar API and a solution compatible with react router v4 (any router really, including next/router). Worth considering react-capture-metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants