-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support react-router v4 #35
Comments
We recently took some time to try and implement react-metrics with react-router v4. We did hit an issue where pageviews did not appear to be behaving correctly. Here's a gif of our log. You can see as we route around it seems to cancel the previous pageview session as if it didn't succeed, then starts a new one. |
Just wondering is there any progress on this at all? |
@GazzaHazza there are no plans for us to move to react-router 4, so unfortunately we're not working on supporting this in react-metrics. However we're 100% open for a pull request to support this 👍 |
@potench any update on that PR? |
For anyone still having issues with this - we worked to develop a similar API and a solution compatible with react router v4 (any router really, including |
Hi,
First thanks for this great library!
Is react-metrics supports react-router4?
If no is there any plan/timeline for this?
If yes, is there anything special need to be done?
Thanks!
Gilad
The text was updated successfully, but these errors were encountered: