-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelist of production database(s) #70
Comments
I assume you mean whitelist of dev databases, otherwise it would useless. The problem is that local database often has the same name as production database. Maybe would could create e.g. table |
Something like that, I have not figured this out, just posting an idea. :-) |
Yep, this is needed. This could probably best be implemented as a check against an environment variable. It probably should be an opt-in featured. The env name could be defined in the configuration. Also it should be noted this is mostly preventing an user error and not adding very much “security”. With this in mind, the reset command could also ask for a nonce such as current datetime string. |
I would like to add new configuration option to extension. Something like |
Closing it, don't need it anymore. |
Isn't it possible to just deregister the command from DI services? |
Yes, use: services:
migrations.resetCommand: false |
I have an idea about whitelisted database which will prevent of calling
migration:reset
command. Just for security reasons. What do you think?The text was updated successfully, but these errors were encountered: