Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appointments): Write Talk link to event #5573

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 10, 2023

How to test

  1. Have Talk set up
  2. Create an appointment config, enable the Talk link integration
  3. Open the booking page
  4. Book
  5. Confirm
  6. Open the event as organizer

main: Event has no location set
here: Event has location set to the Talk URL

@ChristophWurst
Copy link
Member Author

/backport to stable4.5

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8120b9) 24.67% compared to head (dcb2524) 24.67%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5573   +/-   ##
=========================================
  Coverage     24.67%   24.67%           
  Complexity      406      406           
=========================================
  Files           241      241           
  Lines         10693    10693           
  Branches       1739     1739           
=========================================
  Hits           2639     2639           
  Misses         8054     8054           
Flag Coverage Δ
javascript 15.67% <ø> (ø)
php 62.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala miaulalala merged commit bcde3fc into main Nov 10, 2023
41 checks passed
@miaulalala miaulalala deleted the fix/appointments/write-talk-link-to-event branch November 10, 2023 12:00
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants