Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shared calendars as appointment conflict calendars #3786

Closed
1 task done
ChristophWurst opened this issue Dec 2, 2021 · 16 comments · Fixed by nextcloud/server#48621 or #6411
Closed
1 task done

Allow shared calendars as appointment conflict calendars #3786

ChristophWurst opened this issue Dec 2, 2021 · 16 comments · Fixed by nextcloud/server#48621 or #6411
Assignees
Labels
2. developing Work in progress enhancement New feature request Feature: Appointments

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 2, 2021

Is your feature request related to a problem? Please describe.

As a user I might have calendars shared to me by other users, e.g. a company-wide calendar.

Describe the solution you'd like

It would be nice if I could select that shared calendar for appointment conflicts as well. Then company-wide events would also block appointment slots.

Describe alternatives you've considered

N/a

Additional context

@violoncelloCH

This comment has been minimized.

@ChristophWurst

This comment has been minimized.

@ChristophWurst ChristophWurst added enhancement New feature request and removed enhancement-proposed labels Dec 17, 2021
@reos-rcrozier
Copy link

I was about to make a feature request similar to this, but am going to comment here instead.

In our case most often Appointments are to be used for arranging meetings with an external party (who can't see shared calendars). For this reason it would be most useful to have an Appointments URL that can be a combination of the public Appointment calendars of several users.

For example, if several people in the company are trying to arrange an appointment with some external party you would ideally send them one link which provides the appointments available that work for all three employees. This would be really handy.

This seems different from what you propose because one has to set up a new Appointments set for every combination of users to be present at a meeting.

@Blechlawine
Copy link

would this also apply to subscription calendars as well? Or just calendars shared within nextcloud?

@reos-rcrozier
Copy link

reos-rcrozier commented May 8, 2022

@Blechlawine if you're replying to me, I was only thinking of calendars shared within Nextcloud, but actually I mean the Appointments sets shared within Nextcloud,

My idea is users can set up their own appointments sets, just as one can now, and I could somehow select from them to make the combined appointments set for several people.

@Blechlawine
Copy link

@reos-rcrozier I was replying to op, but what your're describing sounds very useful as well

@ChristophWurst
Copy link
Member Author

I'm sure there are cases where subscriptions as conflict source make sense 👍

I just don't know if the change is in scope for this ticket when someone picks it up. We can re-evaluate afterwards and create a another ticket if not.

@rasos
Copy link

rasos commented Feb 7, 2023

We have an organization wide calendar with team meetings which is shared by an organization-admin account. That should be definitely be taken into account when checking for conflicts to offer free time slots.

@pjrobertson
Copy link
Contributor

pjrobertson commented Apr 19, 2024

It seems like the server isse was fixed in NC 24.0.8 and 25.0.2 - does this mean that we can revisit this issue now? See nextcloud/server#30068

@ChristophWurst
Copy link
Member Author

nextcloud/server#30068 was closed by a script

@pjrobertson
Copy link
Contributor

You're right, I missed that. I was trying to investigate this today. It seems like it should actually be possible right now though, without changing the server.

Right now the calendars are taken from selectableConflictCalendars() here. This in turn gets its base calendars to filter from the store getter ownSortedCalendars().

Could we not just add a new getter/get the base calendars and then make sure not to filter out the .filter(calendar => !calendar.isSharedWithMe). I'll submit a PR with this thinking

@ChristophWurst
Copy link
Member Author

Try but I don't think it will work. The backend logic will fail to access those calendars and therefore conflicts are not detected.

@pjrobertson
Copy link
Contributor

I put out a PR #5934, but I think I understand what you're saying now. I'm still struggling to set up a testing environment that includes my local calendar app, so haven't been able to test if this actually works or not

@ChristophWurst
Copy link
Member Author

You can find some resources for dev envs at https://nextcloud.com/developer

@pjrobertson
Copy link
Contributor

Yeah, I've been through that multiple times but there's little info on testing an existing app, and when I tried it it was throwing all sorts of errors. I unfortunately don't have time to debug for half a day :(

@viktorix

This comment was marked as duplicate.

@ChristophWurst ChristophWurst moved this from 🧭 Planning evaluation to 📄 To do in 💌 📅 👥 Groupware team Oct 2, 2024
@SebastianKrupinski SebastianKrupinski changed the title Allow shared (read-only) calendars as appointment conflict calendars Allow shared calendars as appointment conflict calendars Oct 8, 2024
@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation / ideas to 🎉 Done in 🖍 Design team Nov 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Nov 4, 2024
@github-project-automation github-project-automation bot moved this from ☑️ Done to 📄 To do in 💌 📅 👥 Groupware team Nov 12, 2024
@ChristophWurst ChristophWurst moved this from 📄 To do to 🏗️ In progress in 💌 📅 👥 Groupware team Nov 14, 2024
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Nov 14, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature request Feature: Appointments
Projects
Status: 🎉 Done
8 participants