Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calender-Page scrolling area is way too long #165

Open
FabianSimonGross opened this issue Jan 21, 2023 · 5 comments
Open

Calender-Page scrolling area is way too long #165

FabianSimonGross opened this issue Jan 21, 2023 · 5 comments
Labels
bug Something isn't working not important Something that could be implemented, but is not important or even that useful.

Comments

@FabianSimonGross
Copy link
Member

You basically can scroll into Oblivion on /calendar which is not a good user experience.

@alexhorn alexhorn added the bug Something isn't working label Jan 22, 2023
@alexhorn
Copy link
Member

This is because our implementation of the tab control makes all tabs as long at the longest tab. Since react-swipeable-views seems to be deprecated anyway, we should consider replacing it.

@M4GNV5
Copy link
Member

M4GNV5 commented Jan 23, 2023

A simple fix would probably be to make all vies empty except the currently active one, should be an easy fix.
Is there a way to get the current active tab from a SwipeableTabs instance?

@alexhorn
Copy link
Member

@M4GNV5 During the swipe motion two tabs have to be rendered at once, so I'm not sure that will work

@Robert27 Robert27 added this to the SoSe 2023 milestone Mar 6, 2023
@M4GNV5
Copy link
Member

M4GNV5 commented Mar 11, 2023

With the new split between /calendar and /events this problem is way less present. Do we even care enough to keep this issue open?

@Robert27
Copy link
Member

You are right. I think we can close the issue as not implemented or mark it as unimportant for now.

@Robert27 Robert27 removed this from the SoSe 2023 milestone Mar 11, 2023
@M4GNV5 M4GNV5 added the not important Something that could be implemented, but is not important or even that useful. label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working not important Something that could be implemented, but is not important or even that useful.
Projects
None yet
Development

No branches or pull requests

4 participants