Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test last stable vpp releases and do update if no problems occurred #24

Open
denis-tingaikin opened this issue Jan 30, 2024 · 11 comments
Open
Assignees

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jan 30, 2024

Plan:

  1. Check and test all stable releases since our current vpp version. For testing, use forwarder-vpp docker tests and NSM integration tests.
  2. If no problem occurred, just do an update
  3. Otherwise, provide a table with the next information: vpp version, which tests don't work
  4. [Optional] Find a root cause of problems and reproduce it via pure VPP.
  5. [Optional] Report found problems to vpp
  6. [Optional] Commit fixes.
@NikitaSkrynnik
Copy link
Collaborator

NSM doesn't work with VPP v24.02 and Calico stilll uses v24.02-rc0. I think it's reasonable to wait for a new release from Calico and then update VPP in NSM

@denis-tingaikin denis-tingaikin moved this from In Progress to Blocked in Release v1.13.0 Mar 15, 2024
@denis-tingaikin denis-tingaikin moved this from Blocked to Moved to next release in Release v1.13.0 Apr 9, 2024
@denis-tingaikin denis-tingaikin moved this to Moved to next release in Release v1.14.0 Sep 24, 2024
@denis-tingaikin denis-tingaikin changed the title Update VPP to the latest version Test last stable vpp releases and do update if no problems occursed Oct 7, 2024
@denis-tingaikin denis-tingaikin changed the title Test last stable vpp releases and do update if no problems occursed Test last stable vpp releases and do update if no problems occurred Oct 7, 2024
@denis-tingaikin denis-tingaikin moved this to In Progress in Release v1.14.1 Oct 14, 2024
@Ex4amp1e
Copy link
Collaborator

Ex4amp1e commented Oct 15, 2024

Plan:

  • vpp 24.06
  • vpp 24.02

Decomposition:

  • Run govpp docker tests without changes - 30m
  • Build govpp based on vpp 24.06 - 4h
  • Run cmd-forwarder-vpp tests based on vpp 24.06 - 2h
  • Build govpp based on vpp 24.02 - 4h
  • Run cmd-forwarder-vpp tests based on vpp 24.06 - 2h

@Ex4amp1e
Copy link
Collaborator

Ex4amp1e commented Oct 15, 2024

Current results:
cmd-forwarder-vpp docker tests fail on vpp v24.06:

            --- FAIL: TestForwarderTestSuite/TestCombinations/Ethernet/Memif (2.53s)
                --- FAIL: TestForwarderTestSuite/TestCombinations/Ethernet/Memif/Kernel (0.66s)
                --- FAIL: TestForwarderTestSuite/TestCombinations/Ethernet/Memif/Memif (0.92s)
                --- FAIL: TestForwarderTestSuite/TestCombinations/Ethernet/Memif/Vxlan (0.95s)

Note: ipv6 pings fail
Full docker log: 24.06.new.txt

vpp v24.02 has been tested and NSM doesn't work #24 (comment)

Possible options:
Option 1: Find the root cause why Ethernet/Memif tests do not work in vpp code
Option 2: Wait vpp v24.10 (looks like it should be released at the end of Oct 2024) and test it

@denis-tingaikin
Copy link
Member Author

cc @szvincze

@Ex4amp1e Ex4amp1e moved this from In Progress to Todo in Release v1.14.1 Oct 16, 2024
@elajkat
Copy link

elajkat commented Oct 30, 2024

@elajkat
Copy link

elajkat commented Oct 30, 2024

I am not sure I use the govpp api diff in correct way but the API diff for v23.06 to v24.06:
https://pastebin.com/jQjPWdWN

(I used the command:
$ cd ~/temp; git clone https://github.com/FDio/vpp; git checkout v24.06; cd ~/vpp; git checkout v23.06; govpp vppapi diff --against ~/temp/vpp/
)
Perhaps worth to check first the API diff why those tests are failing.

(The API diff for 23.06=>24.10 is here: https://pastebin.com/L52EqTzX )

@NikitaSkrynnik
Copy link
Collaborator

Current plan:

  • Update vpp to the latest release
  • Run docker tests in cmd-forwarder-vpp
  • If docker tests work then run all tests
  • If docker tests don't work then reproduce the same setup from the failed tests on plain vpp

@NikitaSkrynnik
Copy link
Collaborator

We've tested vpp v24.10 on our CI and docker tests. There is a problem with memif interfaces. Particularly tests with vpp endpoint don't work.

Current plan:

  • test kernel2memif scenario on plain vpp
  • if it works then find the difference between our setup and the plain vpp setup

@elajkat
Copy link

elajkat commented Nov 28, 2024

Hi, you reproduced the failure (memif with VPP 24.10) with the integration-k8s-kind environment? I try to reproduce it in my local env.

@NikitaSkrynnik
Copy link
Collaborator

NikitaSkrynnik commented Nov 29, 2024

Yes, I used our integration tests. Tests work if I launch them separately with different forwarders. But if I run the whole basic suite all of them fail except the first one. It looks like we don't clean resources on forwarder properly. The same behaviour is in docker tests. Plain vpp memif tests work correctly. Current plan:

  • debug docker tests

@NikitaSkrynnik
Copy link
Collaborator

Current state:

  1. Docker tests has been fixed after disabling direct memif feature in cmd-forwarder-vpp: code
  2. Integration-tests don't work even without direct memif. Debugging of Kernel2Memif has shown that the problem is with memif interfaces. cmd-nse-vpp shows error no free tx slots after several successful pings. Manual setup of Kernel2Memif with two plain vpp instances doesn't have this problem.

@denis-tingaikin denis-tingaikin moved this from In Progress to Blocked in Release v1.15.0 Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Moved to next release
Status: Moved to next release
Status: Todo
Status: Blocked
Development

No branches or pull requests

4 participants