Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified LogUniform/Jeffrey's Prior? #91

Open
ThomasGWilson opened this issue Feb 14, 2023 · 2 comments
Open

Modified LogUniform/Jeffrey's Prior? #91

ThomasGWilson opened this issue Feb 14, 2023 · 2 comments
Assignees
Labels
documentation Issue related to the documentation

Comments

@ThomasGWilson
Copy link

Hi Néstor,

In some of the parameterisation of RV analysis (notably semi-amplitude) it can be beneficial to set the distribution to LogUniform/Jeffrey's to avoid over-estimating the final value by better sampling low values compared to a Uniform distribution. However, this can cause an under-estimation by the same logic.

A good compromise can be the Modified LogUniform/Jeffrey's (https://github.com/j-faria/LogUniform/blob/caed56d92eed0bd9398c11eb88ce2476077a6ffa/loguniform/LogUniform.py#L214) which is parameterised by a "knee" value in which the distribution switches from Uniform to LogUniform/Jeffrey's, and an upper bound.

This appears to work well within the Kima package and I was wondering if you've thought of adding it to Juliet?

Cheers,

Tom

@nespinoza
Copy link
Owner

Hi @ThomasGWilson,

Indeed, this prior is great and it has already been implemented in juliet by @JohannesBuchner:

def transform_modifiedjeffreys(x, hyperparameters):

This was done a while ago (3 years ago!), but I totally forgot to update the documentation on it. I'll mark this as something I need to include in the docs.

For reference, the usage is as follows:

  • Name of the prior: modjeffreys
  • Parameters: turn (value below which prior is uniform), b (maximum value of the prior)

Usage in a juliet-like, prior.dat file for fitting, e.g., the RV semi-amplitude:

K_p1 modjeffreys 1,100

here, turn = 1 and b = 100. Let me know if this makes sense!

Néstor

@nespinoza nespinoza self-assigned this Feb 15, 2023
@nespinoza nespinoza added the documentation Issue related to the documentation label Feb 15, 2023
@ThomasGWilson
Copy link
Author

Hi @nespinoza,

That's great! Thanks and thanks to @JohannesBuchner for preempting my problem by three years!

Cheers,
Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue related to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants