Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibility to know evry single transit depth (each r_1 and r_2) #69

Open
MohammadEftekhar opened this issue Oct 26, 2021 · 7 comments
Open
Labels
documentation Issue related to the documentation enhancement New feature or request

Comments

@MohammadEftekhar
Copy link

Dear Nestor

Is it possible to reach every single transit depth, in order to every single r_1 and r_2?

thank you
Mohammad

@nespinoza
Copy link
Owner

Hi Mohammad,

Not yet, but I've thought of implementing this though. Should be very similar (and easier than) the TTV implementation.

N.

@nespinoza nespinoza added the enhancement New feature or request label Mar 16, 2022
@LucaNap
Copy link

LucaNap commented Jun 1, 2024

This would be very useful, indeed. I also think that there should be a way of outputting the duration of the fitted transit model as well! (at some point, even the duration of single transits for TTV, TDVs..)

@nespinoza
Copy link
Owner

Hi folks! We've already implemented in the latest version of juliet the possibility to fit different transit depths simultaneously (thanks so @Jayshil's efforts!). You would do so by doing something like:

p_p1_TESS     uniform 0., 1.
p_p1_JWST    uniform 0., 1.

And so on. I haven't had time to document this, but likely will do so in the next few months! Will be closing this once docs are updated, but will leave the issue open for the time being.

N.

@nespinoza nespinoza added the documentation Issue related to the documentation label Jun 1, 2024
@LucaNap
Copy link

LucaNap commented Jun 2, 2024

Great, @nespinoza !
Did you mean:

p_p1_TESS_0
p_p1_TESS_1
...

like the transit times, or did you mean to fit different depths only for different instruments? And if it's exactly like the transit times (T_p1_TESS_0... etc), what about the r1, r2 parametrization?

By the way, having at least the transit duration as an optional output of any transit fitting, would be extremely valuable.

@nespinoza
Copy link
Owner

Hi @LucaNap,

No, the implementation I described above fits depths on different instruments, which might have common transit parameters. As in:

P_p1                 normal 4.1,0.01
t0_p1                normal 2455242.,0.01
.
.
.
p_p1_TESS1     uniform 0., 1.
p_p1_TESS2    uniform 0., 1.

In theory, with this framework you can still do what you want to do --- the t0's can come from different instruments too, so you can divide first manually a lightcurve into different chunks, and fit a different depth and time-of-transit for each lightcurve (assuming they are "different instruments"). You can link, e.g., mflux, q1, q2, etc., to be the same for different instruments (e.g., mflux_TESS1_TESS2) and that would be equivalent to what you want to do.

N.

@nespinoza
Copy link
Owner

As for the r1 and r2 parameters --- no, only p can be done like those.

@nespinoza
Copy link
Owner

nespinoza commented Jun 3, 2024

And as for the question about outputting the transit duration, it is useful, but I prefer to leave that to the user for now :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue related to the documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants