-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement interface injections #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matyrobbrt
added
enhancement
New feature or request
new plugin
This request is for a new JST plugin
labels
Jul 5, 2024
Last commit published: e6b2af8880ad69df47853162340e1b192bbe7ed3. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #33' // https://github.com/neoforged/JavaSourceTransformer/pull/33
url 'https://prmaven.neoforged.net/JavaSourceTransformer/pr33'
content {
includeModule('net.neoforged.jst', 'jst-cli')
includeModule('net.neoforged.jst', 'jst-cli-bundle')
}
}
} |
shartte
requested changes
Jul 5, 2024
...aceinjection/src/main/java/net/neoforged/jst/interfaceinjection/InjectInterfacesVisitor.java
Outdated
Show resolved
Hide resolved
...aceinjection/src/main/java/net/neoforged/jst/interfaceinjection/InjectInterfacesVisitor.java
Outdated
Show resolved
Hide resolved
...aceinjection/src/main/java/net/neoforged/jst/interfaceinjection/InjectInterfacesVisitor.java
Outdated
Show resolved
Hide resolved
...aceinjection/src/main/java/net/neoforged/jst/interfaceinjection/InjectInterfacesVisitor.java
Show resolved
Hide resolved
...ection/src/main/java/net/neoforged/jst/interfaceinjection/InterfaceInjectionTransformer.java
Outdated
Show resolved
Hide resolved
interfaceinjection/src/main/java/net/neoforged/jst/interfaceinjection/StubStore.java
Outdated
Show resolved
Hide resolved
interfaceinjection/src/main/java/net/neoforged/jst/interfaceinjection/StubStore.java
Outdated
Show resolved
Hide resolved
interfaceinjection/src/main/java/net/neoforged/jst/interfaceinjection/StubStore.java
Show resolved
Hide resolved
interfaceinjection/src/main/java/net/neoforged/jst/interfaceinjection/StubStore.java
Outdated
Show resolved
Hide resolved
interfaceinjection/src/main/java/net/neoforged/jst/interfaceinjection/StubStore.java
Show resolved
Hide resolved
Co-authored-by: shartte <[email protected]>
shartte
approved these changes
Jul 5, 2024
shartte
added a commit
to neoforged/NeoFormRuntime
that referenced
this pull request
Jul 5, 2024
See neoforged/JavaSourceTransformer#33 Adds a new `--interface-injection-data` parameter used to specify the location of interface injection data files. --------- Co-authored-by: Sebastian Hartte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new plugin that can be used to inject interfaces to classes, creating stubs for recomp.
The JSON syntax is quite simple:
The class names are in the format of
com/some/package/Outer$Inner
.Generics are supported, as they'll be pasted verbatim.
A
TYPE_USE
annotation marker may be added to the classes, for eventual runtime validation that something will inject that interface in prod.