Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to look up which sources specify a certain target #13

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented Sep 24, 2024

This PR adds a way to look up which sources specify a certain target. This is intended to be used to provide details when an AT causes a coremod to fail, such as when a failed operated on by the field-to-method transformer is made public.

@XFactHD XFactHD added the enhancement New feature or request label Sep 24, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Sep 25, 2024

  • Publish PR to GitHub Packages

Last commit published: 3f8603395783a80eff86c043aec72c0bda88e8b2.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #13' // https://github.com/neoforged/AccessTransformers/pull/13
        url 'https://prmaven.neoforged.net/AccessTransformers/pr13'
        content {
            includeModule('net.neoforged.accesstransformers', 'at-cli')
            includeModule('net.neoforged.accesstransformers', 'at-modlauncher')
            includeModule('net.neoforged', 'accesstransformers')
        }
    }
}

@Shadows-of-Fire
Copy link

Well now the a test is failing, I'm not sure why though, your latest commit was just doc changes.

Which unfortunately means we have a flaky test, screm. Not even sure if it's related to these changes

Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be a flaky test, but rather somehow the newly-added test weren't ran in the original commit, and did run in the new commit that added docs.

In this case, it looks like the test expects only the filename, but the actual result contains the full path.

@XFactHD XFactHD requested a review from sciwhiz12 December 15, 2024 02:33
@sciwhiz12 sciwhiz12 merged commit 3ffc89d into neoforged:10.0.x Dec 24, 2024
2 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as AccessTransformers version 10.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants