From 3a0b82245aa538b3e2e77167de914e182ba6f34b Mon Sep 17 00:00:00 2001 From: leendertvanwolfswinkel Date: Tue, 18 Jul 2023 23:32:36 +0200 Subject: [PATCH 1/5] verzoekjes voor Nici :octopus: --- source/d_1d_objects.rst | 9 +++++++++ source/h_1d2d_exchange.rst | 6 ++++++ source/h_boundary_conditions.rst | 4 ++++ source/h_subgrid.rst | 13 ++++--------- 4 files changed, 23 insertions(+), 9 deletions(-) diff --git a/source/d_1d_objects.rst b/source/d_1d_objects.rst index 7586ddcc..7576e911 100644 --- a/source/d_1d_objects.rst +++ b/source/d_1d_objects.rst @@ -232,6 +232,9 @@ Attributes - \- - *Deprecated* +.. todo:: + Nieuwe grondwater attributen toevoegen + Notes for modellers ^^^^^^^^^^^^^^^^^^^ @@ -702,6 +705,9 @@ Attributes - \- - *Deprecated* +.. todo:: + Nieuwe grondwater attributen toevoegen + .. _manhole_notes_for_modellers: Notes for modellers @@ -1212,6 +1218,9 @@ Attributes - \- - *Deprecated* +.. todo:: + Nieuwe grondwater attributen toevoegen + .. _pipe_notes_for_modeller: Notes for modellers diff --git a/source/h_1d2d_exchange.rst b/source/h_1d2d_exchange.rst index 245fb4e0..337897db 100644 --- a/source/h_1d2d_exchange.rst +++ b/source/h_1d2d_exchange.rst @@ -155,3 +155,9 @@ The embedded element modifies the storage of the 2D cell it is embedded in. The Cross-sectional area in embedded flowlines """""""""""""""""""""""""""""""""""""""""" The cross-sectional area that is used in the 1D flow calculation is determined in a way similar to how the storage is handled. The part of the 1D cross-section that is below the DEM pixels is used, the rest is ignored. The cross-sectional area that is used for the calculation of 2D flow is unaltered by the embedded elements that pass through the cells. + +Exchange between 1D and groundwater +----------------------------------- + +.. todo:: + @Nici kan jij hier uitleggen op welke manier de uitwisseling tussen 1D en grondwater wordt berekend? diff --git a/source/h_boundary_conditions.rst b/source/h_boundary_conditions.rst index 88664809..045eafed 100644 --- a/source/h_boundary_conditions.rst +++ b/source/h_boundary_conditions.rst @@ -1,3 +1,7 @@ +.. todo:: + @Nici deze pagina is sowieso heel summier. Kan jij relevante info toevoegen en evt. als er dingen specifiek gelden voor grondwater, deze expliciet noemen? + + .. _boundary_condtions: Boundary conditions diff --git a/source/h_subgrid.rst b/source/h_subgrid.rst index 29194997..ac6e925d 100644 --- a/source/h_subgrid.rst +++ b/source/h_subgrid.rst @@ -26,16 +26,11 @@ The basic idea behind the subgrid method, is that water levels vary much more gr An example of a computational cell with a bathymetry defined on the subgrid. -Input ------ +Groundwater storage +------------------- -Users define for the grid generation a cell size (of the finest grid resolution) and the number of refinement layers. A computational cell consists always of an even number of subgrid cells. In addition, the user needs to define where and if refinements should be defined. One can define polygons or lines to indicate these areas and the refinement level. - -Some facts and figures ----------------------- - -- The use of high resolution information goes hand in hand with large amounts of data. To compress this data, it is stored during the computations in tables. More information about this can be found in :ref:`tables`. -- There are more variables defined at the high resolution grid; such as roughness, infiltration capacity and hydraulic connectivity. These will be introduced later in the documentation. +.. todo:: + @Nici kan jij hier uitleggen hoe subgrid wordt gebruikt voor het berekenen van de volume/waterstandsrelatie als er ook grondwater is? .. _tables: From e2c407ca68c58fb69c29b9c7c39b01e1eb2e0b3f Mon Sep 17 00:00:00 2001 From: leendertvanwolfswinkel Date: Thu, 14 Sep 2023 16:54:28 +0200 Subject: [PATCH 2/5] Update h_boundary_conditions.rst --- source/h_boundary_conditions.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/h_boundary_conditions.rst b/source/h_boundary_conditions.rst index 6076b602..c35602a2 100644 --- a/source/h_boundary_conditions.rst +++ b/source/h_boundary_conditions.rst @@ -13,7 +13,7 @@ Boundary conditions can be used for 1D flow, 2D surface flow and 2D groundwater Types ----- -A boundary condition must define one variable, so that the computational core can calculate the flow based on the values of the neighbouring node or flow-line. You can define one of the following variables in a boundary condition: +A boundary condition must define one variable, so that the computational core can calculate the flow based on the values of the neighbouring node or flowline. You can define one of the following variables in a boundary condition: * Water level, a user defines a water level (time series). This value is fixed at the boundary cell (1D domain) or for all cells along the boundary (2D surface and groundwater domains). From 01cdcfbbfbb81d6966465e11edc804331b7b19b0 Mon Sep 17 00:00:00 2001 From: "nicolette.volp" Date: Fri, 24 May 2024 14:31:43 +0200 Subject: [PATCH 3/5] conflict --- source/d_1d_objects.rst | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/source/d_1d_objects.rst b/source/d_1d_objects.rst index e46e6d85..9324f408 100644 --- a/source/d_1d_objects.rst +++ b/source/d_1d_objects.rst @@ -1235,10 +1235,6 @@ Attributes - \- - *Deprecated* -<<<<<<< HEAD -.. todo:: - Nieuwe grondwater attributen toevoegen -======= When using the 3Di Schematisation Editor ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -1246,7 +1242,7 @@ When using the 3Di Schematisation Editor - To draw a single pipe, the geometry must have exactly 2 vertices. A line with more than 2 vertices will be split into several pipes. - To digitize a trajectory of multiple pipes, first digitize the manholes, fill in the bottom levels, and then draw the pipe trajectory over these manholes by adding a vertex at each of the manholes. The pipes that are generated will use the manhole's bottom levels as invert levels and the *connection nodes* and *manholes* will be added automatically. ->>>>>>> master + .. _pipe_notes_for_modeller: From 401bfa54a9fd96efd85650d8eac58a58306de4ba Mon Sep 17 00:00:00 2001 From: leendertvanwolfswinkel Date: Wed, 11 Sep 2024 15:30:39 +0200 Subject: [PATCH 4/5] Groundwater attributes description added --- source/d_1d_objects.rst | 41 +++++++++++++++++++++++++++++++++----- source/h_1d2d_exchange.rst | 2 ++ 2 files changed, 38 insertions(+), 5 deletions(-) diff --git a/source/d_1d_objects.rst b/source/d_1d_objects.rst index 1f956b4d..e1fe8979 100644 --- a/source/d_1d_objects.rst +++ b/source/d_1d_objects.rst @@ -252,9 +252,24 @@ Attributes - No - \- - *Deprecated* - -.. todo:: - Nieuwe grondwater attributen toevoegen + * - Exchange thickness + - exchange_thickness + - decimal number + - No + - m + - The thickness of the porous layer that the water needs to flow through to reach the groundwater, see :ref:`1d2d_groundwater_exchange` + * - Hydraulic conductivity in + - hydraulic_conductivity_in + - decimal number + - No + - \- + - Hydraulic conductivity for water flowing from the groundwater to the channel, see :ref:`1d2d_groundwater_exchange` + * - Hydraulic conductivity out + - hydraulic_conductivity_out + - decimal number + - No + - \- + - Hydraulic conductivity for water flowing from the channel to the groundwater, see :ref:`1d2d_groundwater_exchange` When using the 3Di Schematisation Editor @@ -815,9 +830,25 @@ Attributes - No - \- - *Deprecated* + * - Exchange thickness + - exchange_thickness + - decimal number + - No + - m + - The thickness of the (porous) pipe wall that the water needs to flow through to reach the groundwater (or v.v.), see :ref:`1d2d_groundwater_exchange` + * - Hydraulic conductivity in + - hydraulic_conductivity_in + - decimal number + - No + - \- + - Hydraulic conductivity for water flowing from the groundwater into the pipe, see :ref:`1d2d_groundwater_exchange` + * - Hydraulic conductivity out + - hydraulic_conductivity_out + - decimal number + - No + - \- + - Hydraulic conductivity for water flowing from the pipe into the groundwater, see :ref:`1d2d_groundwater_exchange` -.. todo:: - Nieuwe grondwater attributen toevoegen .. _manhole_notes_for_modellers: diff --git a/source/h_1d2d_exchange.rst b/source/h_1d2d_exchange.rst index 2d9e5aa9..962e2137 100644 --- a/source/h_1d2d_exchange.rst +++ b/source/h_1d2d_exchange.rst @@ -153,6 +153,8 @@ For double connected elements this implies: A_{1D2D} = L_{1D2D} H_{1D2D} = L_{bank} H_{1D2D} +.. _1d2d_groundwater_exchange: + Exchange between 1D and groundwater ----------------------------------- From f915e8309d5cfd21a84c05c8be041b66a85df796 Mon Sep 17 00:00:00 2001 From: leendertvanwolfswinkel Date: Wed, 11 Sep 2024 15:50:43 +0200 Subject: [PATCH 5/5] Redacting --- source/h_1d2d_exchange.rst | 8 ++++---- source/h_subgrid.rst | 14 ++++---------- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/source/h_1d2d_exchange.rst b/source/h_1d2d_exchange.rst index 962e2137..3b188f1e 100644 --- a/source/h_1d2d_exchange.rst +++ b/source/h_1d2d_exchange.rst @@ -158,10 +158,10 @@ For double connected elements this implies: Exchange between 1D and groundwater ----------------------------------- -Groundwater interacts with channel and pipes. In 3Di we allow couplings between the 1D and the 2D domain. There are various options that determine the flow, the material of the pipe/channel, the surrounding soil of the groundwater etc. For this 3Di focusses on the large scale effect of the interaction and not on the detailed micro-scale flow. 3Di computes the flux between the two domains based on a diffusive equation, similar to the Darcy equation: +Groundwater (2D domain) can interact with channels and pipes (1D domain). The flow is governed by various parameters: the material of the pipe/channel, the surrounding soil of the groundwater, et cetera. 3Di focuses on the large scale effect of the interaction and not on the detailed micro-scale flow. 3Di computes the flux between the two domains based on a diffusive equation, similar to the Darcy equation: .. math:: - :label: darcy_1d2d + :label: 1D2D groundwater exchange equation Q_{1D2D} = -A_{1D2D} \kappa_{in/out} \frac{\partial \eta}{\partial \delta} @@ -176,11 +176,11 @@ The wet cross-sectional area is based on the length and the wetted perimeter of .. figure:: image/h_1d2d_groundwaterexchange.png :figwidth: 400 px - :alt: connected_to_grw + :alt: Sketch of 1D-2D groundwater exchange and the wetted perimeter in red depending on the flow direction. Sketch of 1D-2D groundwater exchange and the wetted perimeter in red depending on the flow direction. -Each exchange is forced by a water level gradient and scaled by the hydraulic conductivity. Depending on the material, considering pipes or depending on the bed coverage, considering a channel the in and out going flow rates can scale differently. Therefor a in- and a out-going hydraulic conductivity value can be defined. Another scaling factor is the thickness of the pipe or the bed of the channel. +Each exchange is forced by a water level gradient and scaled by the hydraulic conductivity. Depending on the pipe wall material or the channel bed characteristics, the incoming and outgoing flow rates can scale differently. Therefore, an incoming and an outgoing hydraulic conductivity value can be defined. Another scaling factor is the thickness of the pipe or the bed (e.g. the layer of leaves and other non-decomposed organic matter) of the channel. Breach flow diff --git a/source/h_subgrid.rst b/source/h_subgrid.rst index e2709688..6c840328 100644 --- a/source/h_subgrid.rst +++ b/source/h_subgrid.rst @@ -13,11 +13,11 @@ Nowadays, detailed bathymetry information becomes more and more available. Howe Examples of flow in a flume, where a slight change in bathymetry strongly affects the flow. -The key assumption of the subgrid method, is that water levels vary much more gradually, than the bathymetry. In most methods used for hydrodynamic computations, water levels are assumed to be uniform within a computational cell. Traditionally, this is also assumed for the bathymetry within such a cell. The subgrid-based method allows the bathymetry to vary within a computational cell, while the water level remains uniform. In 3Di two grids are defined; a high resolution subgrid and a coarse(r) computational grid. +The key assumption of the subgrid method, is that water levels vary much more gradually than the bathymetry. In most methods used for hydrodynamic computations, water levels are assumed to be uniform within a computational cell. Traditionally, this is also assumed for the bathymetry within such a cell. The subgrid-based method allows the bathymetry to vary within a computational cell, while the water level remains uniform. In 3Di, two grids are defined; a high resolution *subgrid* and a coarser *computational grid*. -All input data, such as the bathymetry, roughness and infiltration rates can be defined on the high resolution grid, while the computations are performed on the coarse computational grid. Volumes and cross-sectional areas are based using the high resolution bathymetry information. The variation of the bathymetry within a computational cell, related to a 2D surface water cell means that a cell can be dry, wet or partly wet. +All input data, such as the bathymetry, roughness and infiltration rates, can be defined on the high resolution grid, while the computations are performed on the coarse computational grid. Volumes and cross-sectional areas are calculated using the high resolution bathymetry information. The variation of the bathymetry within a computational cell, related to a 2D surface water cell means that a cell can be dry, wet or partly wet. -For ground water computational cells, the depth of the impervious layer is assumed to be uniform. The storage capacity in a ground water cell is based on the high resolution bathymetry information. This implies that a ground water cell can also be dry, partly full and maximally filled. This happens when the ground water level reaches the highest level of the bathymetry within a computational cell. +For groundwater computational cells, the depth of the impervious layer is assumed to be uniform. The storage capacity in a groundwater cell is based on the high resolution bathymetry information. This implies that a groundwater cell can also be dry, partly full or completely full. This happens when the groundwater level reaches the highest level of the bathymetry within a computational cell. The subgrid method has three implications: @@ -34,19 +34,13 @@ The subgrid method has three implications: An example of a computational cell with a bathymetry defined on the subgrid. -Some facts and figures ----------------------- - -- The use of high resolution information goes hand in hand with large amounts of data. To compress this data, it is stored during the computations in tables. More information about this can be found in :ref:`subgrid_tables`. -- There are more variables defined at the high resolution grid; such as roughness, infiltration capacity and hydraulic connectivity. These will be introduced later in the documentation. -- Users define for the grid generation a cell size (of the finest grid resolution) and the number of refinement layers. A computational cell consists always of an even number of subgrid cells. In addition, the user needs to define where and if refinements should be defined. One can define polygons or lines to indicate these areas and the refinement level. .. _subgrid_tables: Subgrid tables -------------- -The high resolution subgrid data is compressed in tables that allow fast access during the simulation. These tables describe the relation between water level and the following variables: +The use of high resolution information also means that more data is used during the simulation. 3Di stores this data in subgrid tables to limit the memory usage and allow fast access during the simulation. These tables describe the relation between water level and the following variables: * Volumes per computational cell (1D, 2D) * Cross-sectional area per half of cell face (2D)