Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug forcing tag naming strategy with prefix v #264

Open
bueno-felipe opened this issue Sep 12, 2024 · 1 comment
Open

Bug forcing tag naming strategy with prefix v #264

bueno-felipe opened this issue Sep 12, 2024 · 1 comment

Comments

@bueno-felipe
Copy link

From version 18.0.6 and so on the NearestVersionLocator only read tags that use v as prefix, as you can see in this commit:
7d369f6

https://github.com/nebula-plugins/nebula-release-plugin/blame/c3850c0a954fafce9064c94ad1c47a58f94381fd/src/main/groovy/nebula/plugin/release/git/command/GitReadCommand.groovy#L115

But the base plugin gradle-git allow users to extend the tagStrategy to define how the git tag will be created, through setting:

#build.gradle
release {
    tagStrategy {
       prefixNameWithV = false
    }
}

or

#build.gradle
release {
    tagStrategy {
       toTagString = { version -> "${version}" }
    }  
}

Shouldn't it to be consider as a bug?

@bueno-felipe
Copy link
Author

This issue could be related: #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant