Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] - Update for Jupyterlab 4 compatibility #4

Closed
kcpevey opened this issue Nov 28, 2023 · 2 comments
Closed

[ENH] - Update for Jupyterlab 4 compatibility #4

kcpevey opened this issue Nov 28, 2023 · 2 comments
Assignees
@nkaretnikov

Comments

@kcpevey
Copy link

kcpevey commented Nov 28, 2023

Feature description

Now that Jupyterlab 4 is available and projects are moving onto it, we need to test this package and see what needs to be done to update it for compatibility.

Value and/or benefit

JLab 4 compatibility

Anything else?

No response
@kcpevey kcpevey mentioned this issue Nov 28, 2023
Closed
@kcpevey
Copy link
Author

kcpevey commented Nov 29, 2023

jupyter-scheduler introduced breaking changes when they upgraded to JLab 4. This probably means that this package will require some changes as well.

@kcpevey kcpevey mentioned this issue Jan 10, 2024
Closed
@nkaretnikov nkaretnikov self-assigned this Jan 10, 2024
@nkaretnikov
Copy link
Collaborator

nkaretnikov commented Jan 11, 2024 •
edited
Loading

No changes needed. Replied in nebari-dev/nebari#2195 (comment).

Suggested to merge #3 as part of this Nebari release. Waiting for Dharhas to respond on the linked issue.

UPD: Dharhas approved my idea to merge the PR, so I did. I'll re-test and update the issue.

UPD2: Submitted a PR with a new release here nebari-dev/nebari-docker-images#108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkaretnikov nkaretnikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkaretnikov @kcpevey