Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing permission prompt #109

Closed
ShortDevelopment opened this issue Sep 19, 2023 · 10 comments
Closed

Missing permission prompt #109

ShortDevelopment opened this issue Sep 19, 2023 · 10 comments
Assignees
Labels
type::bug Something isn't working
Milestone

Comments

@ShortDevelopment
Copy link
Member

Suddenly there was a problem when transferring data from the phone to the PC - "There is no permission!". The PC is not displayed in the window, while I can receive data from the PC to the phone. I have not noticed such problems before. The application worked stably and without failures. All rights are granted: access to the location (when using the application), as well as to the drive. The MAC address is also registered. It's just that at some point the application stopped working. I don't know what the reason might be. The application version is official (previously), the device is Redmi Note 8T (Android 11).


https://discord.com/channels/1059414830295035904/1152195242091618346

@ShortDevelopment ShortDevelopment added the type::bug Something isn't working label Sep 19, 2023
ShortDevelopment added a commit that referenced this issue Sep 19, 2023
@ShortDevelopment ShortDevelopment self-assigned this Oct 3, 2023
@moriel5
Copy link

moriel5 commented Oct 22, 2023

Can confirm that this bug is still present on 1.5.2-beta, at least on my Razer Phone 2 running stock Android 9.

Initially, after inputting my Bluetooth MAC address, it complained about missing permissions (despite me having already granted them from the get-go), but after revoking them and giving them when the app invoked the prompts, I was able to recieve files.

When I attempted to send files, it again complained about missing permissions, however revoking and granting permissions did not help (it did not even ask for the storage permission this time, which makes sense), and henceforth, this issue rendered both sending and receiving broken, even if I paired my laptop to my phone.

Great work, though (now, if there only was something standardized between different Linux ecosystems (i.e. DEs) and distros)!

@ShortDevelopment
Copy link
Member Author

@moriel5 Thank you for your research! I'll look into this next week.

For a possible linux implementation have a look at nearby-sharing/cli#1 (comment)

@moriel5

This comment was marked as off-topic.

@moriel5
Copy link

moriel5 commented Oct 26, 2023

An update: I just ran some more tests, and I can recieve files again, despite the app complaining about missing permissions.

However, I cannot send anything, as my laptop does not appear in the list inside the app.

@ShortDevelopment
Copy link
Member Author

@moriel5 I have requested permissions that were needed for android 12+ but did not exist below 😅
Should be fixed now...

Your computer not being listed should be sth different though (Feel free to have a look at the FAQ or ask on the discord)

@moriel5
Copy link

moriel5 commented Oct 30, 2023

Thanks, I'll test things in the next version. And I'll take another look at the FAQ (I try avoiding Discord wherever possible, due to their privacy practices and real-world system resource requirements).

Update: The FAQ is not helpful in my case, as it only says to to file the setup ensure that all of the settings are correct, which they are in my case.

Additionally, further testing is showing that in general, visibility of my Razer Phone 2 is pretty inconsistent, regardless of the router used, however that is a subject for another issue, and it may be related to the fact that my laptop isn't recognized by my phone (as the only thing that is consistent, is that my phone always stops being recognized after attempting to scan for devices to sent to).

@ShortDevelopment
Copy link
Member Author

Still a bug, I'll add more logging to diagnose further...

@ShortDevelopment
Copy link
Member Author

@moriel5 Just open separate issues for each the problems you detected. Then we can discuss them separately 🙂

ShortDevelopment added a commit that referenced this issue Nov 5, 2023
@moriel5
Copy link

moriel5 commented Nov 6, 2023

I shall do that once I get around to retesting (just so that what I post will be accurate).

@ShortDevelopment
Copy link
Member Author

I've removed this prompt entirely as it has too many false positives.
The user gets prompted to grant permissions every time they open the app,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants