[Epoch Sync] Merkle tree size for a block mismatches with the block ordinal? #12256
Comments
This was referenced Oct 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 18, 2024
Issue: #11932 Implements EpochSyncProof validation, according to: - [design doc](https://docs.google.com/document/d/14Itc9Hs7ewTRmcGANid9UCaYcJzaLzzM7FsvYYIFKDY/edit#heading=h.p2oiicluwd6o) - [`epoch_sync.rs`](https://github.com/near/nearcore/blob/d6d6e4782f7d57a7b7acc2894e1668355012ff74/core/primitives/src/epoch_sync.rs) Summary: - Move block merkle proof retrieval logic from `Chain` to a separate trait (`MerkleProofAccess`). Make `Store` implements this trait so that we can `get_block_proof` while serving `EpochSyncRequest` from a separate thread and having no access to `Chain`. - Refactor `verify_approval` and `compute_bp_hash` so that we can use it for proof validation. - Derive `first_block_info_in_epoch` from block header. - Implement the validation logic. - Add 2 more fields to the proof - `EpochSyncProofPastEpochData::protocol_version` - `merkle_proof_for_first_block` generated at height of final block of current epoch. - Apparently, we need to add even more to enable generating `merkle_proof_for_first_block` at the bootstrapped node. That will be done as a follow-up issue: #12255. - Create a bunch of follow-up issues (added to the [tracking issue](near/near-one-project-tracking#73)): - #12255 - #12256 - #12258 - #12259 - #12260
|
This is expected. block_ordinal stored in the header is 1-based; everywhere else is 0-based. Will remove the TODO and make it clearer when tackling the general merkle tree task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Follow-up task to #12020.
Investigate, why
+1is needed in:The text was updated successfully, but these errors were encountered: