Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which components will need NEPs to merge with near-sdk-rs? #32

Open
encody opened this issue Aug 22, 2022 · 4 comments
Open

Which components will need NEPs to merge with near-sdk-rs? #32

encody opened this issue Aug 22, 2022 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@encody
Copy link
Contributor

encody commented Aug 22, 2022

This is essentially the question: Which derive macros expose external methods that are not yet standardized via an NEP?

Component Exposes Interface? NEP Standard
standard::*
Event
Migrate
Owner
Pause
Rbac
Slot
utils::*
Approval / SimpleMultisig

In order to be merged into SDK, a component's Exposes Interface? column should match its NEP Standard column.

@encody encody added documentation Improvements or additions to documentation question Further information is requested labels Aug 22, 2022
@encody encody added this to the Audit-ready milestone Aug 22, 2022
@encody encody self-assigned this Aug 22, 2022
@ryancwalsh
Copy link
Contributor

@encody If you have a moment, I'm curious about a couple things:

This is essentially the question: Which derive macros expose external methods that are not yet standardized via an NEP?

Are you saying that the question "Which code will require an NEP to be approved?" is equivalent to "Which derive macros expose external methods that are not yet standardized via an NEP?"

I feel like I haven't found a clearly documented answer to "Which code will require an NEP to be approved?" and didn't feel like Max's answer was super clear either, so I'm just curious what is leading you to your interpretation.

In order to be merged into SDK, a component's Exposes Interface? column should match its NEP Standard column.

I don't understand the wording of this.

Currently I see that Migrate, Owner, and Pause all have Xs for NEP Standard. So I initially thought you were saying that they'd need NEPs. But then because of that wording of the last sentence, it sounds like you're considering making changes to NCT to switch the ✅s of those 3 rows of the "Exposes Interface" column back to Xs.

@encody
Copy link
Contributor Author

encody commented Aug 22, 2022

@ryancwalsh :

@encody If you have a moment, I'm curious about a couple things:

This is essentially the question: Which derive macros expose external methods that are not yet standardized via an NEP?

Are you saying that the question "Which code will require an NEP to be approved?" is equivalent to "Which derive macros expose external methods that are not yet standardized via an NEP?"

That is my reductive interpretation, yes.

In order to be merged into SDK, a component's Exposes Interface? column should match its NEP Standard column.

I don't understand the wording of this.

Currently I see that Migrate, Owner, and Pause all have Xs for NEP Standard. So I initially thought you were saying that they'd need NEPs. But then because of that wording of the last sentence, it sounds like you're considering making changes to NCT to switch the ✅s of those 3 rows of the "Exposes Interface" column back to Xs.

I'm saying so long as the first column is equal to the second column, we're good. It doesn't matter which column changes, just so long as they're equal. If that means removing previously exposed interfaces, fine, if that means proposing & standardizing an NEP, fine.

@encody
Copy link
Contributor Author

encody commented Aug 22, 2022

To be honest, I think that all of the derive macros are generally good/correct in their current implementations, so I'd say we should take a look at NEP-standardizing all three of the deviant components: Migrate, Owner, Pause.

@ryancwalsh
Copy link
Contributor

@encody Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants