-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: added documentation for root level and signer module #32
Conversation
@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 5! @PolyProgrammist received 25 Sloth Points for reviewing and scoring this pull request. We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Left some comments. Overall, looks great
Please check these 2 comments. Overall, already looks good to me. About the docs, maybe if you can add any references to docs.near.org, that's good. But anyway, not that important, can be done later |
@PolyProgrammist I have added some more info to look at near_ledger impl. |
🥁 Score it! @akorchyn, please ask your peers to score the PR using |
@race-of-sloths score 6 |
🏆 Score recorded!It looks like @PolyProgrammist provided a score of 6, but based on our Fibonacci scoring rules, we've adjusted it to 5. Tip We accept only the following Fibonacci numbers [0, 1, 2, 3, 5, 8, 13] for scoring |
Also, changed API of the Signer to work with a seed phrase as &str instead of String
Improved naming convention
@race-of-sloths