Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Bug with gossip sync #34

Open
Darth-Coin opened this issue Dec 15, 2022 · 10 comments
Open

Bug with gossip sync #34

Darth-Coin opened this issue Dec 15, 2022 · 10 comments

Comments

@Darth-Coin
Copy link

Description

Weird channels names appeared after udpate OBW to v0.2.0-11.

  • Normal channel open with a clearnet node Eternal.Sovereigm, few weeks ago
  • OBW vers. 0.1.8
  • Also opened one with Jiraiya and one with SATM
  • using clearnet, never Tor

After update OBW to 0.2.0-11 some weird gossip sync happen:

  • Jiraiya HC appeared to be etleneum,com (I never open with etleneum.com and is also another IP)
    image

  • Eternal.Sovereign node appeared now as [onion] with displaying his old onion address (no longer available)
    image

Eternal said that only changed the alias few days ago and other wallets / channels are connected well.
Notice in Amboss its old onion address
image

Steps I did:

  • removed HC etleneum and added again Jiraiya as HC. Worked, all ok, channel online
  • Switched to Tor, but the normal channel with Eternal still shows the old address and stays offline.

Will wait few days more to see if the gossip will sync correctly and will report back here.

fiatjaf added a commit that referenced this issue Dec 31, 2022
a dirty fix to #34 that is probably being
caused by some node somewhere, probably acinq, sending very old `node_announcement`
messages in reply to our naïve queries.
@fiatjaf
Copy link
Contributor

fiatjaf commented Dec 31, 2022

@Darth-Coin if you can do me a favor, please download the apk from https://github.com/nbd-wtf/obw/actions/runs/3810252555 and live with it for a while so we can see if this problem keeps happening. A proper fix would require doing a big refactor, but this should be enough if the problem is just the ACINQ node replaying very old gossip messages on us.

@Darth-Coin
Copy link
Author

@fiatjaf I install it but is coming as separate new app not overwrite the old one.
The thing is that with the original OBW I can't make export of the channels to import in any other version. See issue #35
So I can't really test this dev version.
Let me know how should I proceed now. If I can make the backup in OBW I could import into this dev version and see how is doing. But I can't trigger the backup (I have 2 HC + 1 normal chan).
Yes, I could FC that chan (is with Eternalkr, no problem to communicate) but then we can't test to see this fix in v0.2.0 is ok.

@fiatjaf
Copy link
Contributor

fiatjaf commented Dec 31, 2022

I'll do that other thing.

@fiatjaf
Copy link
Contributor

fiatjaf commented Dec 31, 2022

Actually if you can just use this dev version with a random key and get an HC from Jiraiya and never use it for anything, just wait to see if it changes from Jiraiya to Etleneum eventually.

@Darth-Coin
Copy link
Author

Darth-Coin commented Dec 31, 2022

Ah OK then, I misunderstood. I can do that sure. testing it for a while.

EDIT testing

  • opened a HC with Jiraiya
  • sent 50k sats from lntxbot, received instantly
  • will continue using it for a while
    Testing to send:
  • sent 1234 sats to legend.lnbits, all OK
  • sent 1235 sats to another lnbits instance, all OK

@Darth-Coin
Copy link
Author

  • I updated to new v0.2.1
  • made the backup channels
  • imported the backup + seed into an other device with v0.2.1
  • SATM HC channel OK
  • Jiraiya HC channel, imported as etleneum. Removed and add Jiraiya again, worked. OK
  • Eternal.Sovereign normal channel is still synced wrong as described in the beginning and is still offline.

@Darth-Coin
Copy link
Author

Actually if you can just use this dev version with a random key and get an HC from Jiraiya and never use it for anything, just wait to see if it changes from Jiraiya to Etleneum eventually.

I check almost twice per day using OBW_DEV version, to see if Jiraiya is changing the name. It is not updating.
If you are still looking into fix this issue let me know. I can keep that broken channel open until you find a solution.
Maybe this will help others with the same issue.
But if you think there's no fix for this, also let me know so I can FC the channel and move on.

@fiatjaf
Copy link
Contributor

fiatjaf commented Jan 5, 2023

Well, if it is not changing back to Etleneum that is a good thing. Does the channel appear as online? I think you can stop checking now. Thank you very much for your help. Is the channel working in the main OBW too or has that one changed to Etleneum?

@Darth-Coin
Copy link
Author

yes, the Jiraiya chan is active online and working on both versions (0.2.1 and dev)
Only the normal channel with Eternal node is still offline and showing onion address.

@Darth-Coin
Copy link
Author

@fiatjaf this morning I tried again to use OBW_DEV version.
As usual, I open OBW, wait to sync the channel (I have only one HC with Jiraiya) and sent the payment.
I get this error, even that I wait several minutes and no sign on top of sync.
image

Then I tried from another device, the normal OBW (latest version) and payment worked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants