Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support streaming messages #73

Open
bruffridge opened this issue Mar 29, 2024 · 6 comments
Open

support streaming messages #73

bruffridge opened this issue Mar 29, 2024 · 6 comments
Labels
enhancement New feature or request waiting for External party has to do something before this can be worked on.

Comments

@bruffridge
Copy link
Member

I think support for the new Assistants API streaming was added to deep-chat.

OvidijusParsiunas/deep-chat#137

@bruffridge bruffridge added the enhancement New feature or request label Mar 29, 2024
@jackitaliano
Copy link
Contributor

Yes, it was, but not there. That is simulating streaming. It still doesn't return anything until the whole message is received, but it then slowly "streams" the content. Results actually in a longer wait time.

However, actual streaming was added, but only in dev so far.
OvidijusParsiunas/deep-chat#155

Should be in a coming update, but will also result in some other changes that should be addressed due to deep-chat changes.

@jackitaliano
Copy link
Contributor

Update on previous comment.

Tried out streaming functionality in dev, and it works well to stream text results. Some issues remain, so shouldn't be put into Bidara yet. I opened one issue so far regarding download links on deep-chat, and will look out for others.

Should wait on this issue until deep-chat's are resolved.

@jackitaliano
Copy link
Contributor

Deep-chat maintainer is working on a solution to issue I mentioned. He said it would be non-trivial, so I'll keep tabs on that.

OvidijusParsiunas/deep-chat#157

@jackitaliano
Copy link
Contributor

This issue seems to be resolved in deep-chat-dev v9.0.164; however, some other issues remain as mentioned #88, so I'll wait to put that in.

@bruffridge bruffridge added the waiting for External party has to do something before this can be worked on. label Apr 17, 2024
@bruffridge
Copy link
Member Author

I was working on this a little, and one issue I encountered is I wasn't able to get the responseInterceptor to fix the image links since the function is called once for each token returned from streaming, so couldn't use the existing find and replace code. So moving on for now. I'm not sure how valuable streaming is anyways other than slightly better UX.

@jackitaliano jackitaliano mentioned this issue Jun 12, 2024
@jackitaliano
Copy link
Contributor

Have fixed some of the issues with streaming on our end; however, one new bug presented itself on deep-chat's. Have an issue opened, but don't expect it to be resolved for another week due to the maintainer being OOO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting for External party has to do something before this can be worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants