You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reading through the body of sample(), I realize that statements about the optional acor dependency in the README, that I also propagated into log messages in #24, are not correct. The README says:
Note that acor is not required to run the sampler, it simply calculates the effective chain length for output in the chain file.
But looking at the code in sample(), when acor is missing, the local Neff variable is set to zero. That means that when acor is missing, the subsequent comparison against Neff will always fail.
I suggest that a more transparent approach would be for sample() to check if parameter neff > 0 before starting the run, then fail immediately with a helpful error message if acor is missing, since it can never satisfy the request to terminate after the requested number of samples is collected. I also suggest updating statements about acor in the README and revisiting related log output from #24.
The text was updated successfully, but these errors were encountered:
chimaerase
changed the title
sample() parameter neff is not respected when optional acor dependency missing
sample() parameter neff not respected when optional acor dependency missing
Jul 12, 2022
chimaerase
changed the title
sample() parameter neff not respected when optional acor dependency missing
neff not respected when optional acor dependency missing
Jul 12, 2022
This is mostly fixed by #51, though perhaps it would be an improvement to fail immediately when neff is supplied but acor is not available, rather than only failing the first time we actually try to call acor.
Reading through the body of
sample()
, I realize that statements about the optionalacor
dependency in the README, that I also propagated into log messages in #24, are not correct. The README says:But looking at the code in
sample()
, whenacor
is missing, the localNeff
variable is set to zero. That means that whenacor
is missing, the subsequent comparison againstNeff
will always fail.I suggest that a more transparent approach would be for
sample()
to check if parameterneff > 0
before starting the run, then fail immediately with a helpful error message ifacor
is missing, since it can never satisfy the request to terminate after the requested number of samples is collected. I also suggest updating statements aboutacor
in the README and revisiting related log output from #24.The text was updated successfully, but these errors were encountered: