Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Loose tags for container builds ? #263

Open
ednxzu opened this issue Jun 4, 2024 · 5 comments
Open

[feature request] Loose tags for container builds ? #263

ednxzu opened this issue Jun 4, 2024 · 5 comments
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Comments

@ednxzu
Copy link

ednxzu commented Jun 4, 2024

would it be possible to get loose tags on containers (X, X.Y) for releases ?

I would really like to use your container images other nomad related projects, and being able to pin to looser versions would be nice.

I will look into making a PR for this.

Best,

@multani
Copy link
Owner

multani commented Jun 4, 2024

Hey @ednxzu, if you can make a PR for this, that would be super cool and I'd definitely consider it 👍

@multani multani assigned multani and unassigned multani Jun 4, 2024
@multani multani added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Jun 4, 2024
@ednxzu
Copy link
Author

ednxzu commented Jun 4, 2024

I don't really have a clear idea yet of how to do it without disrupting the build process too much, but I'll give it a shot !

@ednxzu
Copy link
Author

ednxzu commented Jun 13, 2024

@multani Quick question for the implementation, do we want to tag the -rc/-beta/etc.. tags as latest minor/major ? or should it be the latest stable ?

@multani
Copy link
Owner

multani commented Jun 14, 2024

@ednxzu I would keep the latest stable as minor/major and exclude rc/beta.

I'm not sure how doable is it, but if it's possible, it would be great to have a latest-rc and/or latest-beta for instance?

@ednxzu
Copy link
Author

ednxzu commented Jun 14, 2024

That depends haha, how free am I in executing this ?

It seems rather complicated with the current repository structure and logic, especially for implementing latest-rc and latest-beta.

I made a github action for this very purpose a few months ago. docker-matrix-generator that might be really fitted for this type of stuff.

This is more so done to generate build matrixes, instead of building only a single image for each minor like here.

one idea (the main one) is to have an additional step in the build action that checks the nomad_version output against the github list of tags for hashicorp/nomad, and returns an object like

{
  "latest": false,
  "latest_minor": true,
  "latest_major": false,
  "latest_rc": false,
  "latest_beta": false
}

this can be used here to dynamically add tags to images.

issue: need to most likely add python/ some other high level language scripting in the repo to do this check (way too complicated for a bash script imo)

if that's ok I can probbly get it working sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

2 participants