Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scipy from iridium_extractor_flowgraph.py? #190

Closed
jmfriedt opened this issue Mar 19, 2024 · 3 comments
Closed

Remove scipy from iridium_extractor_flowgraph.py? #190

jmfriedt opened this issue Mar 19, 2024 · 3 comments

Comments

@jmfriedt
Copy link

Is the import scipy in
https://github.com/muccc/gr-iridium/blob/master/python/iridium_extractor_flowgraph.py
needed? I have removed it and the flowgraph seeems to run happily. Removing scipy removes a huge dependency for running gr-iridium on embedded boards (e.g. Raspberry Pi 4) running a Buildroot generated operating system.

@Sec42
Copy link
Member

Sec42 commented Mar 30, 2024

I seem to remember that it was needed for some debugging output/feature. Checking the git history I can't recall any details though. Maybe @schneider42 remembers something?

@schneider42
Copy link
Member

This must be a leftover from the pure Python implementation. I'm going to remove it.

@schneider42
Copy link
Member

Pushed the change directly to master. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants