Fork, Suggestion

[hobbyquaker]

Hello Marcus,

I published a rewrite of your lib here: https://github.com/hobbyquaker/lgtv2

I removed discovery and command wrappers and made a basic lib that just encapsulates the websocket connection handling, the pairing process and the callback handling. Further Improvements are:

• exports a constructor, so you can connect to multiple TVs
• Auto-reconnects to the TV
• Is an EventEmitter, so you get events for connect/discconect/prompt/error
• Callback handling without EventEmitter, Callback timeouts

My Intention for doing this rewrite was lgtv2mqtt, a tool I'm using in my MQTT based home automation and that depends on lgtv2.

If you like the changes I made I would suggest to rebuild your lib including your command wrappers that depends on lgtv2 and another lib that handles lg webos auto-discovery, so everything is modular.

Would be glad to hear your opinion on that,
all the best,
Sebastian

[msloth]

Hey, thanks! Great! I'm new to more complex sw in node.js/js so I'm still learning. This will be a great learning experience for me, so thanks a lot!

I don't really know what I'll do with this lib though. I have a lack of time and motivation to keep it up to date and going forward.... 🍶