Exact score based algorithm optimizations #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging like it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fairly free optimizations. I benchmarked briefly for graphs with 16 vertices.
local_score_directly: reduces execution time from ~2.5s to ~1.2s (so roughly 1s faster)@viewwhich I think can hurt because the submatrix is not contiguous: reduces execution time from ~1.2s to ~1.1sWe should definitely fix the first point (that was just an oversight that these calls are memoized)...
Second point we could benchmark GES on larger graphs first
UPDATE: the
@viewthing doesn't make a big difference for GES, so I have no big preference whether we keep it