Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Simplifying SaveFrame function #23

Open
fenuks opened this issue Feb 23, 2014 · 2 comments
Open

Simplifying SaveFrame function #23

fenuks opened this issue Feb 23, 2014 · 2 comments

Comments

@fenuks
Copy link

fenuks commented Feb 23, 2014

This:

for(y=0; y<height; y++){
    fwrite(pFrame->data[0]+y*pFrame->linesize[0], 1, width*3, pFile);

can be done with this:

fwrite(pFrame->data[0], 1, width*height*3, pFile);

which is easier to understand, at least for me, since I'm not acknowledged with ffmpeg.

@mpenkov
Copy link
Owner

mpenkov commented Feb 24, 2014

Would you care to make a pull request?

@fenuks
Copy link
Author

fenuks commented Feb 25, 2014

I would, but is there any sense? It's about deleting 2 lines of code and adding one. In order to make pull request I would have to fork repo. It's not worth the efford, but if you insist I'll make pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants