Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRootFolderPath() Should be Synchronous #65

Open
chrstinalin opened this issue Jun 24, 2024 · 0 comments
Open

getRootFolderPath() Should be Synchronous #65

chrstinalin opened this issue Jun 24, 2024 · 0 comments
Labels
nice-to-have Functionality or features that would be nice to have in Assay.

Comments

@chrstinalin
Copy link
Contributor

chrstinalin commented Jun 24, 2024

Currently, getRootFolderPath() is an asynchronous function as it prompts the user to input a root folder if non exists. However, the async modifier is bubbling up in a way that's causing/can cause implementation headaches.

Instead, there should be a synchronous getRootFolderPath() and separate asynchronous action for the check to be called 1) on launch, and 2) on change of the root folder setting.

@chrstinalin chrstinalin added the nice-to-have Functionality or features that would be nice to have in Assay. label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice-to-have Functionality or features that would be nice to have in Assay.
Projects
None yet
Development

No branches or pull requests

1 participant