Addon Validation Error when using static initialization blocks in add-on code

[qt-kaneko]

So, the problem is in class static initialization block. When it exists, error occurres, even if it is empty, even if there is no other code. (See in scripts/player.js:13)

P.S. In browser all works fine.

publish.zip

• A new version of an existing add-on.

• Listed.

• https://addons.mozilla.org

• 11:10 UTC+2

[diox]

Hi,

It looks like an error with our scanners, yes. Weirdly, I can't reproduce locally with the version we use in production... But I see it in the logs, and you're right, it's caused by the class static block. We'll investigate.

[diox]

Depends on estools/estraverse#120

[diox]

We've made a fix in our private scanners that should resolve the problem. It should be in production on 2022-04-21 after 19:00 UTC+2.

[ioanarusiczki]

@diox

A bit confusing that the reporter says
P.S. In browser all works fine.

But I tested the .zip file attached above on dev and stage and I could upload it plus a new version.
Also, it works through the API (the new feature) on dev and stage.

Right now on -prod the validation fails from dev hub or using the APIs.

[diox]

P.S. In browser all works fine.

That's because it works if you install the unsigned xpi through about:debugging (or when disabling signatures). i.e. that was purely something on the AMO side, Firefox supported that syntax correctly.

[ioanarusiczki]

@diox Ah ok, which means that my testing method was correct.