Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox crashes at startup #23903

Open
Left47 opened this issue Dec 19, 2024 · 5 comments
Open

Firefox crashes at startup #23903

Left47 opened this issue Dec 19, 2024 · 5 comments
Assignees
Labels
Crash Crashes the application

Comments

@Left47
Copy link

Left47 commented Dec 19, 2024

Logs

You can help us by sending us either your crash logs or Firefox logs. Instructions on how to do this here.

Steps to reproduce

Open the app

Expected behavior

It opens

Actual behavior

It crashes

Device & build information

  • Device: Iphone 12 pro (iOS 18.1)
  • Build version: 133.4

Notes

Attachments:

Client-2024-12-19-164425.ips.txt

@Left47 Left47 added the Crash Crashes the application label Dec 19, 2024
@nbhasin2
Copy link
Contributor

Going to see if its related to Kingfisher as we are on version 7.12.0
New version is https://github.com/onevcat/Kingfisher/releases/tag/8.1.3

@nbhasin2
Copy link
Contributor

Update Kingfisher to 8.1.3
https://github.com/onevcat/Kingfisher/releases/tag/8.1.3

@data-sync-user
Copy link
Collaborator

➤ Isabella commented:

QA Notes:

This must be an intermittent crash on iOS 18 as none of us could reproduce.

The fix involved updating a dependency which had some underlying changes, as well as a few changes to our code. Standard regression testing around favicons should cover this. Thanks!

@data-sync-user
Copy link
Collaborator

➤ Isabella commented:

Hi Alina Moldovan, a fix for this was just merged in, could you please test this in the next Nightly build? Thanks! 🙏 We will backport if there’s nothing strange with favicons. Some QA notes are in my comment below.

CCAndres Furlan

@data-sync-user
Copy link
Collaborator

➤ Alina Moldovan commented:

Andrei Bodea will add the nightly testing results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crash Crashes the application
Projects
None yet
Development

No branches or pull requests

4 participants