Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode icons #12

Open
ricardopolo opened this issue Dec 15, 2020 · 3 comments
Open

Don't hardcode icons #12

ricardopolo opened this issue Dec 15, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ricardopolo
Copy link

In our project we have the package of icons from https://materialdesignicons.com/, the one used by Buefy and other big projects.

However this lib uses https://material.io/resources/icons/

This is suboptimal because we have two styles of icons.
So my request would be:

  1. Be able to use other icons, like the ability to use a setting to select which package are you going to use. As example Buefy let you chose between Material Icons and Font Awesome
  2. Don't hardcode icons in the package. Currently, even If I managed to use other icons using HTML I would still have installed the icons I don't need because vue-file-toolbar-menu install them. Make them optional (this could apply to emojis too)
@motla
Copy link
Owner

motla commented Dec 15, 2020

Yes indeed it would be great.
I can't spend much time on this unfortunately.
Could you fork the project, tailor it to your needs and make a pull request?

@motla motla added enhancement New feature or request help wanted Extra attention is needed labels Dec 15, 2020
@ricardopolo
Copy link
Author

I dont have much time right now, but I will try do it it later. Thanks a lot!

@Fanna1119
Copy link

Fanna1119 commented Dec 9, 2021

Will see if I can make some changes for it to support iconify.
https://iconify.design/
https://github.com/antfu/unplugin-icons
I think this is the best step forward for really making it independent from a specific icon package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants