[ES-1984] modified all number to string, default number values also #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zesu22
commented
Dec 4, 2024
zesu22
commented
- all values has been treated as string now
- if you send empty values(null, undefined, empty string), invalid number then it will take the default value
- if you give a valid number, it will be converted to string
- if you pass string and it is a valid one then that value will be used
Signed-off-by: Zeeshan Mehboob <[email protected]>
zesu22
changed the title
Signed-off-by: Zeeshan Mehboob <[email protected]>
ase-101
approved these changes
Dec 5, 2024
Prafulrakhade
approved these changes
Dec 6, 2024
ckm007
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.