Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rate limit failed ci due to failure to upload cache #23

Open
alon-dotan-starkware opened this issue Sep 22, 2024 · 5 comments
Open

rate limit failed ci due to failure to upload cache #23

alon-dotan-starkware opened this issue Sep 22, 2024 · 5 comments
Assignees

Comments

@alon-dotan-starkware
Copy link

alon-dotan-starkware commented Sep 22, 2024

we using lot of steps in our ci, which brings use pretty often to scenarios when we hit the API rate limits...
for example:

Warning: Failed to save: Cache service responded with 429 during upload chunk.
/home/runner/work/_actions/moonrepo/setup-rust/v1/dist/post/index.js:475
                        throw new Error(`Cache upload failed because file read failed with ${error.message}`);
                        ^

Error: Cache upload failed because file read failed with EBADF: bad file descriptor, read
    at ReadStream.<anonymous> (/home/runner/work/_actions/moonrepo/setup-rust/v1/dist/post/index.js:475:31)
    at ReadStream.emit (node:events:519:28)
    at emitErrorNT (node:internal/streams/destroy:169:8)
    at errorOrDestroy (node:internal/streams/destroy:238:7)
    at node:internal/fs/streams:[27](https://github.com/starkware-libs/sequencer/actions/runs/10980431063/job/30486199032?pr=913#step:25:27)2:9
    at FSReqCallback.wrapper [as oncomplete] (node:fs:682:5)

Is it possible to make the upload cache flow optional and to do not failed the entire ci when the upload is not available?

@alon-dotan-starkware alon-dotan-starkware changed the title rate limit failed ci due to failure to upload cahce rate limit failed ci due to failure to upload cache Sep 22, 2024
@milesj
Copy link
Contributor

milesj commented Sep 23, 2024

@alon-dotan-starkware Do you happen to know in what situations this triggers?

@milesj milesj self-assigned this Sep 23, 2024
@alon-dotan-starkware
Copy link
Author

When we have many actions running and we reaching github API rate limits

@alon-dotan-starkware
Copy link
Author

#24

@milesj
Copy link
Contributor

milesj commented Sep 23, 2024

@alon-dotan-starkware Does the rate limit go away if you set the following?

env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@alon-dotan-starkware
Copy link
Author

No, its very common issue you can see it a cross multiple plugins, its based in poor impl.of the http client under the toolkit package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants