Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Iter[String]::join #1257

Open
Yoorkin opened this issue Nov 27, 2024 · 1 comment · May be fixed by #1301
Open

add Iter[String]::join #1257

Yoorkin opened this issue Nov 27, 2024 · 1 comment · May be fixed by #1301
Assignees

Comments

@Yoorkin
Copy link
Collaborator

Yoorkin commented Nov 27, 2024

String::concat was a mistake. In the self parameter, the types in the type constructor can be a concrete type like String. After discussing offline, we will move to Iter[String]::join and make String::concat a function. The join method will be added later because users can always use other methods instead.

Originally posted by @Yoorkin in #1249 (comment)

@Yoorkin Yoorkin self-assigned this Nov 27, 2024
@yj-qin
Copy link
Collaborator

yj-qin commented Nov 27, 2024

Related issue #1171

@hackwaly hackwaly linked a pull request Dec 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants