Syncing to lammps_implementation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance tuning
In order to evaluete the bspline basis the indices of knots that surrounds a given r is needed. If the knots have constant knot spacing then the above operation is a simple division and (int). For non-uniform knots loops are needed
Added uniform/non-unifrom feature to UF3 LAMMPS
fix loss function weights and regularizer bug (redo)
…Explicit array alignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lammps_implementation has changes to align memory of variables (suggested by @fmgjcoppens). Also, other changes were fetched into lammps_implementatio from uf3/develop.