-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/ipvs: include github.com/moby/ipvs #118031
Conversation
The github.com/moby/ipvs seems unmaintained and need fixes. This commit includes the code in the K8s tree. LICENSE is included as-is (must be fixed most likely). Unit-test are omitted since they require NET_ADMIN rights.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: uablrek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md for logging. It's based on logr. |
We should not have "external" code in |
I will probably go for this option, but in another PR |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The github.com/moby/ipvs seems unmaintained and need fixes. This commit includes the code in the K8s tree. LICENSE is included as-is (must be fixed most likely). Unit-test are omitted since they require NET_ADMIN rights.
Most urgent is to fix moby/ipvs#27
But also to convert unstructured logging to structured (using logr probably)
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is an attempt to solve a "unmaintained project" problem discussed in sig/network slack.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
N/A