Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobie.add_image transformations #96

Open
martinschorb opened this issue Mar 23, 2023 · 1 comment
Open

mobie.add_image transformations #96

martinschorb opened this issue Mar 23, 2023 · 1 comment

Comments

@martinschorb
Copy link
Contributor

Hi,

I tried adding some transformations to imported sources. It seems that the parameter in add_image points to a XML-specific function.

if transformation is not None:

What is the best way to include transformation upon data import (multi-modal/ multi-scale registration)? Loading the view and modifying it afterwards?

@constantinpape
Copy link
Contributor

I tried adding some transformations to imported sources. It seems that the parameter in add_image points to a XML-specific function.

Yes, indeed this currently only works for bdv.xml formats. I have started to generalize the functionality to also support ome.zarr here: #94.
However, I realized that it currently doesn't make sense to enable this for ome.zarr, since the transformations supported by it are limited; and the v0.5 release which will significantly extend the transformation functionality in ome.zarr is due soon.
(I still went ahead and merged this, so that an error message is thrown when trying to add an ome.zarr image with transformation).

For some more discussions about the transformation functionality, see also https://forum.image.sc/t/mobie-utils-python-understanding-transformations-and-views/78341/4.

(And we can leave this issue open; I will try to implement the trafo support for ome.zarr as soon as v0.5 is released)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants