writing of related_label #2663
-
|
Small details: if the string related_label in ui_text.yml is written in lower case, single.html display it in uppercase. |
Beta Was this translation helpful? Give feedback.
Replies: 8 comments
-
|
Feel free to submit a pull request to make them consistent. |
Beta Was this translation helpful? Give feedback.
-
|
It's controlled by CSS. Add the following CSS as your custom to override it and restore the default behavior: .page__share-title {
text-transform: initial;
} |
Beta Was this translation helpful? Give feedback.
-
|
Yes but why don't you implement it in the theme ?
Le lun. 24 août 2020 17:26, iBug ♦ <[email protected]> a écrit :
… It's controlled by CSS. Add the following CSS as your custom to override
it and restore the default behavior:
.page__share-title {
text-transform: initial;
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/mmistakes/minimal-mistakes/issues/2663#issuecomment-679195957>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP6H72SHSA6F4NTL5C2YDETSCKBD7ANCNFSM4QIEBCIA>
.
|
Beta Was this translation helpful? Give feedback.
-
|
Maybe I'm misunderstanding what the issue is. The So not exactly sure what you're getting at with the theme doing it. At first I thought you meant there was an inconsistency with title casing between the default string and what is in the sample data file (e.g. Regardless, doesn't really matter either way as that data file is something the user copies to their local repo and should tailor the text to meet their needs. If you don't like the initial caps text... change it. If you don't like the way things are described... change it. This was my intention with providing a file with all the text strings so they could be changed by the user easily. |
Beta Was this translation helpful? Give feedback.
-
|
And what @iBug was getting at, the theme's default styling for those types of headings is to uppercase them. It's purely decorative and part of the theme's design. If you want to change the design, then you can use the CSS above to override that. This theme does have some opinions which is part of the reason it is used so widely. It is in no way meant to be a site builder where you can go in and have options to change every little things via simple configs. |
Beta Was this translation helpful? Give feedback.
-
|
The text is in lower case in ui file but the display is un upper. No reason
to change it because always displayed in upper !
Le lun. 24 août 2020 19:16, Michael Rose <[email protected]> a
écrit :
… Maybe I'm misunderstanding what the issue is. The related_label is 100%
controllable by you the user. There is a default string
<https://github.com/mmistakes/minimal-mistakes/blob/master/_layouts/single.html#L68>
(You May Also Enjoy) that is applied if you don't have a ui-text.yml
<https://github.com/mmistakes/minimal-mistakes/blob/master/_data/ui-text.yml#L29>
data file. But if you have that data file in your repo, then that whatever
text you put in there will be used instead.
So not exactly sure what you're getting at with the theme doing it. At
first I thought you meant there was an inconsistency with title casing
between the default string and what is in the *sample* data file (e.g. You
may also enjoy). Which if that is the case feel free to submit a pull
request changing it so they're both the same titling.
Regardless, doesn't really matter either way as that data file is
something the user copies to their local repo and *should* tailor the
text to meet their needs. If you don't like the initial caps text... change
it. If you don't like the way things are described... change it. This was
my intention with providing a file with all the text strings so they could
be changed by the user easily.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/mmistakes/minimal-mistakes/issues/2663#issuecomment-679256471>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP6H72UQTGDXOK3FY4XVAB3SCKN47ANCNFSM4QIEBCIA>
.
|
Beta Was this translation helpful? Give feedback.
-
|
@jphconstantin That is by design. The text isn't uppercase, it's just styled to be that way.
|
Beta Was this translation helpful? Give feedback.
-
|
Ok. You can close the subject.
Le lun. 24 août 2020 19:24, Michael Rose <[email protected]> a
écrit :
… @jphconstantin <https://github.com/jphconstantin> That is by design. The
text isn't uppercase, it's just styled to be that way.
[image: image]
<https://user-images.githubusercontent.com/1376749/91076172-1769e280-e60d-11ea-906a-09670429870a.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/mmistakes/minimal-mistakes/issues/2663#issuecomment-679260909>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP6H72RVOVFSUTRJHEDKWEDSCKO4TANCNFSM4QIEBCIA>
.
|
Beta Was this translation helpful? Give feedback.
@jphconstantin That is by design. The text isn't uppercase, it's just styled to be that way.