From 40021b6bcf40cb724c4444c79239223c0419ec71 Mon Sep 17 00:00:00 2001
From: mmetc <92726601+mmetc@users.noreply.github.com>
Date: Fri, 4 Oct 2024 13:15:16 +0200
Subject: [PATCH] CI: update coverage ignore list for generated code (#3262)

* CI: update coverage ignore list for generated code

* CI: generate codecov.yml automatically
---
 .github/codecov-ignore-generated.sh        |  17 +++
 .github/codecov.yml                        | 139 ---------------------
 .github/workflows/bats-sqlite-coverage.yml |   4 +
 .github/workflows/go-tests-windows.yml     |   4 +
 .github/workflows/go-tests.yml             |   4 +
 .gitignore                                 |   3 +
 6 files changed, 32 insertions(+), 139 deletions(-)
 delete mode 100644 .github/codecov.yml

diff --git a/.github/codecov-ignore-generated.sh b/.github/codecov-ignore-generated.sh
index 3c896d47be7..0f59b1de4a0 100755
--- a/.github/codecov-ignore-generated.sh
+++ b/.github/codecov-ignore-generated.sh
@@ -4,6 +4,23 @@
 #
 # .github/codecov-ignore-generated.sh >> .github/codecov.yml
 
+cat <<EOT
+# we measure coverage but don't enforce it
+# https://docs.codecov.com/docs/codecov-yaml
+coverage:
+  status:
+    patch:
+      default:
+        target: 0%
+    project:
+      default:
+        target: 0%
+
+# if a directory is ignored, there is no way to un-ignore files like pkg/models/helpers.go
+# so we make a full list
+ignore:
+EOT
+
 find . -name "*.go" | while read -r file; do
     if head -n 1 "$file" | grep -q "Code generated by"; then
         echo "  - \"$file\""
diff --git a/.github/codecov.yml b/.github/codecov.yml
deleted file mode 100644
index 82598c15511..00000000000
--- a/.github/codecov.yml
+++ /dev/null
@@ -1,139 +0,0 @@
-# we measure coverage but don't enforce it
-# https://docs.codecov.com/docs/codecov-yaml
-coverage:
-  status:
-    patch:
-      default:
-        target: 0%
-    project:
-      default:
-        target: 0%
-
-# if a directory is ignored, there is no way to un-ignore files like pkg/models/helpers.go
-# so we make a full list, manually updated - but it could be generated right before running codecov
-ignore:
-  - "./pkg/modelscapi/success_response.go"
-  - "./pkg/modelscapi/get_decisions_stream_response_deleted.go"
-  - "./pkg/modelscapi/login_request.go"
-  - "./pkg/modelscapi/get_decisions_stream_response_links.go"
-  - "./pkg/modelscapi/login_response.go"
-  - "./pkg/modelscapi/add_signals_request_item.go"
-  - "./pkg/modelscapi/blocklist_link.go"
-  - "./pkg/modelscapi/get_decisions_stream_response_deleted_item.go"
-  - "./pkg/modelscapi/decisions_sync_request.go"
-  - "./pkg/modelscapi/get_decisions_stream_response.go"
-  - "./pkg/modelscapi/metrics_request_machines_item.go"
-  - "./pkg/modelscapi/metrics_request.go"
-  - "./pkg/modelscapi/get_decisions_stream_response_new.go"
-  - "./pkg/modelscapi/add_signals_request_item_decisions_item.go"
-  - "./pkg/modelscapi/metrics_request_bouncers_item.go"
-  - "./pkg/modelscapi/decisions_sync_request_item_decisions_item.go"
-  - "./pkg/modelscapi/decisions_delete_request_item.go"
-  - "./pkg/modelscapi/get_decisions_stream_response_new_item.go"
-  - "./pkg/modelscapi/decisions_sync_request_item.go"
-  - "./pkg/modelscapi/add_signals_request.go"
-  - "./pkg/modelscapi/reset_password_request.go"
-  - "./pkg/modelscapi/add_signals_request_item_decisions.go"
-  - "./pkg/modelscapi/decisions_sync_request_item_source.go"
-  - "./pkg/modelscapi/error_response.go"
-  - "./pkg/modelscapi/decisions_delete_request.go"
-  - "./pkg/modelscapi/decisions_sync_request_item_decisions.go"
-  - "./pkg/modelscapi/enroll_request.go"
-  - "./pkg/modelscapi/register_request.go"
-  - "./pkg/modelscapi/add_signals_request_item_source.go"
-  - "./pkg/models/alert.go"
-  - "./pkg/models/metrics_bouncer_info.go"
-  - "./pkg/models/add_signals_request_item.go"
-  - "./pkg/models/add_signals_request_item_decisions_item.go"
-  - "./pkg/models/get_alerts_response.go"
-  - "./pkg/models/watcher_auth_request.go"
-  - "./pkg/models/add_alerts_request.go"
-  - "./pkg/models/event.go"
-  - "./pkg/models/decisions_delete_request_item.go"
-  - "./pkg/models/meta.go"
-  - "./pkg/models/delete_alerts_response.go"
-  - "./pkg/models/topx_response.go"
-  - "./pkg/models/add_signals_request.go"
-  - "./pkg/models/delete_decision_response.go"
-  - "./pkg/models/get_decisions_response.go"
-  - "./pkg/models/add_signals_request_item_decisions.go"
-  - "./pkg/models/source.go"
-  - "./pkg/models/decisions_stream_response.go"
-  - "./pkg/models/error_response.go"
-  - "./pkg/models/decision.go"
-  - "./pkg/models/decisions_delete_request.go"
-  - "./pkg/models/flush_decision_response.go"
-  - "./pkg/models/watcher_auth_response.go"
-  - "./pkg/models/watcher_registration_request.go"
-  - "./pkg/models/metrics_agent_info.go"
-  - "./pkg/models/add_signals_request_item_source.go"
-  - "./pkg/models/add_alerts_response.go"
-  - "./pkg/models/metrics.go"
-  - "./pkg/protobufs/notifier.pb.go"
-  - "./pkg/database/ent/machine_delete.go"
-  - "./pkg/database/ent/decision_query.go"
-  - "./pkg/database/ent/meta_query.go"
-  - "./pkg/database/ent/machine_create.go"
-  - "./pkg/database/ent/alert.go"
-  - "./pkg/database/ent/event_update.go"
-  - "./pkg/database/ent/alert_create.go"
-  - "./pkg/database/ent/alert_query.go"
-  - "./pkg/database/ent/lock_create.go"
-  - "./pkg/database/ent/bouncer_update.go"
-  - "./pkg/database/ent/meta_update.go"
-  - "./pkg/database/ent/decision_create.go"
-  - "./pkg/database/ent/configitem_update.go"
-  - "./pkg/database/ent/machine_query.go"
-  - "./pkg/database/ent/client.go"
-  - "./pkg/database/ent/predicate/predicate.go"
-  - "./pkg/database/ent/lock/where.go"
-  - "./pkg/database/ent/lock/lock.go"
-  - "./pkg/database/ent/mutation.go"
-  - "./pkg/database/ent/migrate/migrate.go"
-  - "./pkg/database/ent/migrate/schema.go"
-  - "./pkg/database/ent/configitem.go"
-  - "./pkg/database/ent/event.go"
-  - "./pkg/database/ent/event_query.go"
-  - "./pkg/database/ent/lock_update.go"
-  - "./pkg/database/ent/meta.go"
-  - "./pkg/database/ent/configitem_query.go"
-  - "./pkg/database/ent/bouncer.go"
-  - "./pkg/database/ent/alert_update.go"
-  - "./pkg/database/ent/meta/meta.go"
-  - "./pkg/database/ent/meta/where.go"
-  - "./pkg/database/ent/decision_update.go"
-  - "./pkg/database/ent/alert_delete.go"
-  - "./pkg/database/ent/lock.go"
-  - "./pkg/database/ent/runtime/runtime.go"
-  - "./pkg/database/ent/alert/alert.go"
-  - "./pkg/database/ent/alert/where.go"
-  - "./pkg/database/ent/runtime.go"
-  - "./pkg/database/ent/bouncer/bouncer.go"
-  - "./pkg/database/ent/bouncer/where.go"
-  - "./pkg/database/ent/hook/hook.go"
-  - "./pkg/database/ent/configitem_create.go"
-  - "./pkg/database/ent/configitem_delete.go"
-  - "./pkg/database/ent/tx.go"
-  - "./pkg/database/ent/decision.go"
-  - "./pkg/database/ent/lock_delete.go"
-  - "./pkg/database/ent/decision_delete.go"
-  - "./pkg/database/ent/machine/where.go"
-  - "./pkg/database/ent/machine/machine.go"
-  - "./pkg/database/ent/event_create.go"
-  - "./pkg/database/ent/decision/where.go"
-  - "./pkg/database/ent/decision/decision.go"
-  - "./pkg/database/ent/enttest/enttest.go"
-  - "./pkg/database/ent/lock_query.go"
-  - "./pkg/database/ent/bouncer_create.go"
-  - "./pkg/database/ent/event_delete.go"
-  - "./pkg/database/ent/bouncer_delete.go"
-  - "./pkg/database/ent/event/event.go"
-  - "./pkg/database/ent/event/where.go"
-  - "./pkg/database/ent/machine.go"
-  - "./pkg/database/ent/ent.go"
-  - "./pkg/database/ent/meta_create.go"
-  - "./pkg/database/ent/bouncer_query.go"
-  - "./pkg/database/ent/meta_delete.go"
-  - "./pkg/database/ent/machine_update.go"
-  - "./pkg/database/ent/configitem/configitem.go"
-  - "./pkg/database/ent/configitem/where.go"
diff --git a/.github/workflows/bats-sqlite-coverage.yml b/.github/workflows/bats-sqlite-coverage.yml
index c1ae9077310..53eb2a51c4d 100644
--- a/.github/workflows/bats-sqlite-coverage.yml
+++ b/.github/workflows/bats-sqlite-coverage.yml
@@ -79,6 +79,10 @@ jobs:
       run: for file in $(find ./test/local/var/log -type f); do echo ">>>>> $file"; cat $file; echo; done
       if: ${{ always() }}
 
+    - name: Ignore-list of generated files for codecov
+      run: |
+          .github/codecov-ignore-generated.sh >> .github/codecov.yml
+
     - name: Upload bats coverage to codecov
       uses: codecov/codecov-action@v4
       with:
diff --git a/.github/workflows/go-tests-windows.yml b/.github/workflows/go-tests-windows.yml
index a31e42cf702..488756d0059 100644
--- a/.github/workflows/go-tests-windows.yml
+++ b/.github/workflows/go-tests-windows.yml
@@ -47,6 +47,10 @@ jobs:
         if(!$?) { cat out.txt | sed 's/ *coverage:.*of statements in.*//' | richgo testfilter; Exit 1 }
         cat out.txt | sed 's/ *coverage:.*of statements in.*//' | richgo testfilter
 
+    - name: Ignore-list of generated files for codecov
+      run: |
+          .github/codecov-ignore-generated.sh >> .github/codecov.yml
+
     - name: Upload unit coverage to Codecov
       uses: codecov/codecov-action@v4
       with:
diff --git a/.github/workflows/go-tests.yml b/.github/workflows/go-tests.yml
index a6c72a91af6..52de434ad9b 100644
--- a/.github/workflows/go-tests.yml
+++ b/.github/workflows/go-tests.yml
@@ -165,6 +165,10 @@ jobs:
         set -o pipefail
         make go-acc | sed 's/ *coverage:.*of statements in.*//' | richgo testfilter
 
+    - name: Ignore-list of generated files for codecov
+      run: |
+          .github/codecov-ignore-generated.sh >> .github/codecov.yml
+
     - name: Upload unit coverage to Codecov
       uses: codecov/codecov-action@v4
       with:
diff --git a/.gitignore b/.gitignore
index 6e6624fd282..d76efcbfc48 100644
--- a/.gitignore
+++ b/.gitignore
@@ -60,3 +60,6 @@ msi
 __pycache__
 *.py[cod]
 *.egg-info
+
+# automatically generated before running codecov
+.github/codecov.yml