Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ordering with shards used #559

Open
patrikwilliam opened this issue Oct 24, 2023 · 2 comments
Open

Wrong ordering with shards used #559

patrikwilliam opened this issue Oct 24, 2023 · 2 comments

Comments

@patrikwilliam
Copy link
Contributor

Pabot has a great feature of shards splitting, but currently does alphabetical order first, splits suites to shards and then orders the suites with ordering file per shard. However, this causes the ordering to be not preserved equally.
E. g.
ABCD -> 2 nodes, order by ACDB -> [AB],[CD] instead of [AC],[DB]. The more suites you have the worse it is. Unfortunately, this is a significant perf problem since you want to end up running all shards equally, which is currently not possible due to the behavior explained (each suite has different duration). This minor change should do the trick #558, but it is not clear to me why the current behavior is as it is and who might benefit that.

@patrikwilliam
Copy link
Contributor Author

Would there be anyone looking into this? Thanks!

@MattiJarvinen
Copy link

The idea is that the shards should execute in the nearly in the same duration. That way all the shards should complete in the fastest combined execution time.

So it picks the shortest test and the longest test into the same pairing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants