Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] null terminate strings #274

Open
grexe opened this issue Nov 16, 2024 · 0 comments
Open

[RFE] null terminate strings #274

grexe opened this issue Nov 16, 2024 · 0 comments

Comments

@grexe
Copy link

grexe commented Nov 16, 2024

I think it's an unnecessary trap, doesn't affect performance or memory consumption and it's also uncommon to pass non null terminated strings to a caller in a C library.

For some reason I could not reliably retrieve strings from MD_ATTRIBUTES' text field even when correctly using the size parameter, so I adapted the build_md_attr method and now it works reliably and transparently without unnecessary client checks.

I'd love to share my changes in a PR to this issue if that's okay with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant