Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0-conf txs with dependent txs in wallet #568

Open
antiochp opened this issue Jan 5, 2021 · 1 comment
Open

0-conf txs with dependent txs in wallet #568

antiochp opened this issue Jan 5, 2021 · 1 comment

Comments

@antiochp
Copy link
Member

antiochp commented Jan 5, 2021

This is a bit of a weird edge case and needs thinking through. Putting it here so we don't forget.

It is possible to "spend" an unconfirmed output in the wallet via --min_conf 0.

And it is possible that an output will 0 confirmations will never confirm.
One scenario is the sender never finalizes the tx, for example.

A tx "spending" this unconfirmed output will not (and cannot) be accepted in the mempool.
So we can build a valid tx in wallet that never reaches the local mempool and will never confirm.
The wallet is not aware of this and will simply show the tx (and associated outputs) as unconfirmed.

grin-wallet info shows funds as "Awaiting Finalization" which is misleading. The tx may have been successfully finalized, just not successfully accepted to the mempool.

@cliik
Copy link
Contributor

cliik commented Jul 9, 2022

This is interesting. Would it make sense to automatically move a transaction to the "unconfirmed" state, when the wallet finalizes a transaction? This ofc would only work for the sender wallet (in SRS flow) that finalizes the tx, unless we introduced another communication round to the receiver 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants