Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting grin-miner with missing plugins directory does not generate a user-facing error #31

Open
thorsteneb opened this issue Aug 8, 2018 · 2 comments

Comments

@thorsteneb
Copy link
Contributor

Starting grin-miner when the plugins directory is missing will create an error message in grin-miner.log, but grin-miner itself is happy to continue running, be connected to grin, and show "starting miner and awaiting first graph time". Expected behavior: User-facing error that the configured plugin can't be found, or the plugin directory is missing entirely.

Error message in logs for that:

Aug 07 16:15:05.091 ERRO Unable to load cuckoo-miner plugin directory, either from configuration or [exe_path]/plugins.

Aug 07 16:15:05.108 ERRO

thread 'mining_controller' panicked at 'Unable to load plugin directory... Please check configuration values': src/bin/plugin.rs:106stack backtrace:

@thorsteneb
Copy link
Contributor Author

Likely related issue, please let me know whether to track separately:

When shutting grin-miner down, with plugin directory missing, it will exit the UI, then just sit there and not terminate. Likely related to the above. Shell at that point looks like this

yorick@Meep:~/grin-miner$ grin-miner
Starting Grin-Miner from config file at: /home/yorick/grin-miner/grin-miner.toml
Starting Grin Miner in UI mode...

and logs show

Aug 07 16:21:06.194 DEBG Client recieved message: Shutdown

Aug 07 16:21:06.195 DEBG Shutting down client controller

A ctrl-c is required to shut down grin-miner

@glemercier
Copy link
Contributor

It seems it was fixed by 2a05cf7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants