Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check why any object can be put in swagger doc and the swagger tests still pass #12

Open
kubantjan opened this issue Mar 8, 2022 · 5 comments

Comments

@kubantjan
Copy link
Member

kubantjan commented Mar 8, 2022

I just tried to change object in some endpoint and the tests are still passing. Maybe we have something wrong with the test setup (in my case I changed the ouput file in export endpoint)

@kubantjan
Copy link
Member Author

kubantjan commented Oct 5, 2022

chekc if it is undestandable, and either close or ask.
this is not from txm repo, but from swagger tester (remove the issue from this repo and create it in the other one) and add it to this project.

@kristinagalik
Copy link

kristinagalik commented Nov 2, 2022

@kubantjan ked zmenim odpoved endpointu napr export txm event na {} even tho ma response nejake required fields, tak mi hadzu testy response code 200 - lebo sa nedeje uz davnejsie spominany response marshalling. ale ked to testujem cez swagger tak mi to krici ze je nieco zle.. mozno pripadne ak sa ti to este deje vies mi napisat presne kroky ako ten problem zreplikovat prosim?

co som ale nasla je, ze endpoint vo file txm_event_api.py na riadku ~96 (@txm_event_api.route('/<int:txm_event_id>', methods=['PUT'])) sa netestuje - a tipujem ze je to tym ze su 2 PUT requesty co maju velmi podobnu (s tym endpointom hned nad nim /default) url tym padom sa asi nejak "prepise"? ked som tam pridala dake veci do url zrazu ho testovalo

vyzera to ze ked su viacere endpointy s rovnakym typom (napr PUT) ze toto je brane ako rovnake (aj ked z postmana to vola spravne):
route('/slovo', methods=['PUT']) je prepisane ak je nieco ako route('/ineslovo', methods=['PUT'])
ale akonahle ten pattern vyzera inak - napr route('/ineslovo/niecodalsie', methods=['PUT']) tak to zrazu testuje

mam to vyriesit vramci druhej swagger issue mild-blue/txmatching#1040? (je to zmena jedneho riadku)

@kubantjan
Copy link
Member Author

  1. @kubantjan will try to reproduce
  2. @kristinagalik will create an issue in swagger tester for the same path issue.

@kristinagalik
Copy link

@kubantjan tato issue uz je v swagger repe

@kubantjan kubantjan assigned kubantjan and unassigned kristinagalik Nov 4, 2022
@kubantjan
Copy link
Member Author

low priority

@kubantjan kubantjan removed their assignment Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants